Citra-emu/citra-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #182 from JosJuice/settings-lifecycle

Browse Source 
Fix SettingsActivity back stack behavior after stop+start
This commit is contained in:
SachinVin 2021-09-11 13:15:54 +05:30 committed by GitHub
commit 6f6f9a0910
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.java
View File

@ -97,13 +97,11 @@ public final class SettingsActivity extends AppCompatActivity implements Setting
} }
@Override @Override
public void onBackPressed() { public void showSettingsFragment(String menuTag, boolean addToStack, String gameID) {
mPresenter.onBackPressed(); if (!addToStack && getFragment() != null) {
return;
} }
@Override
public void showSettingsFragment(String menuTag, boolean addToStack, String gameID) {
FragmentTransaction transaction = getSupportFragmentManager().beginTransaction(); FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();
if (addToStack) { if (addToStack) {
@ -116,7 +114,6 @@ public final class SettingsActivity extends AppCompatActivity implements Setting
} }
transaction.addToBackStack(null); transaction.addToBackStack(null);
mPresenter.addToStack();
} }
transaction.replace(R.id.frame_content, SettingsFragment.newInstance(menuTag, gameID), FRAGMENT_TAG); transaction.replace(R.id.frame_content, SettingsFragment.newInstance(menuTag, gameID), FRAGMENT_TAG);
@ -207,11 +204,6 @@ public final class SettingsActivity extends AppCompatActivity implements Setting
Toast.makeText(this, message, is_long ? Toast.LENGTH_LONG : Toast.LENGTH_SHORT).show(); Toast.makeText(this, message, is_long ? Toast.LENGTH_LONG : Toast.LENGTH_SHORT).show();
} }
@Override
public void popBackStack() {
getSupportFragmentManager().popBackStackImmediate();
}
@Override @Override
public void onSettingChanged() { public void onSettingChanged() {
mPresenter.onSettingChanged(); mPresenter.onSettingChanged();

16
src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivityPresenter.java
View File

@ -22,8 +22,6 @@ public final class SettingsActivityPresenter {
private Settings mSettings = new Settings(); private Settings mSettings = new Settings();
private int mStackCount;
private boolean mShouldSave; private boolean mShouldSave;
private DirectoryStateReceiver directoryStateReceiver; private DirectoryStateReceiver directoryStateReceiver;
@ -45,7 +43,6 @@ public final class SettingsActivityPresenter {
} }
public void onStart() { public void onStart() {
this.mStackCount = 0;
prepareCitraDirectoriesIfNeeded(); prepareCitraDirectoriesIfNeeded();
} }
@ -117,19 +114,6 @@ public final class SettingsActivityPresenter {
NativeLibrary.ReloadSettings(); NativeLibrary.ReloadSettings();
} }
public void addToStack() {
mStackCount++;
}
public void onBackPressed() {
if (mStackCount > 0) {
mView.popBackStack();
mStackCount--;
} else {
mView.finish();
}
}
public void onSettingChanged() { public void onSettingChanged() {
mShouldSave = true; mShouldSave = true;
} }

5
src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivityView.java
View File

@ -55,11 +55,6 @@ public interface SettingsActivityView {
*/ */
void showToastMessage(String message, boolean is_long); void showToastMessage(String message, boolean is_long);
/**
* Show the previous fragment.
*/
void popBackStack();
/** /**
* End the activity. * End the activity.
*/ */