Android: Settings: Center the setting title when no setting description is provided.

src/android/app/src/main/java/org/citra/citra_android/ui/settings/viewholder/CheckBoxSettingViewHolder.java

@@ -36,6 +36,9 @@ public final class CheckBoxSettingViewHolder extends SettingViewHolder {
 
         if (item.getDescriptionId() > 0) {
             mTextSettingDescription.setText(item.getDescriptionId());
+            mTextSettingDescription.setVisibility(View.VISIBLE);
+        } else {
+            mTextSettingDescription.setVisibility(View.GONE);
         }
 
         mCheckbox.setChecked(mItem.isChecked());

src/android/app/src/main/java/org/citra/citra_android/ui/settings/viewholder/DateTimeViewHolder.java

@@ -31,8 +31,12 @@ public final class DateTimeViewHolder extends SettingViewHolder {
     public void bind(SettingsItem item) {
         mItem = (DateTimeSetting) item;
         mTextSettingName.setText(item.getNameId());
+
         if (item.getDescriptionId() > 0) {
             mTextSettingDescription.setText(item.getDescriptionId());
+            mTextSettingDescription.setVisibility(View.VISIBLE);
+        } else {
+            mTextSettingDescription.setVisibility(View.GONE);
         }
     }
 

src/android/app/src/main/java/org/citra/citra_android/ui/settings/viewholder/InputBindingSettingViewHolder.java

@@ -38,7 +38,14 @@ public final class InputBindingSettingViewHolder extends SettingViewHolder {
         mItem = (InputBindingSetting) item;
 
         mTextSettingName.setText(item.getNameId());
-        mTextSettingDescription.setText(sharedPreferences.getString(mItem.getKey(), ""));
+
+        String key = sharedPreferences.getString(mItem.getKey(), "");
+        if (key != null && !key.isEmpty()) {
+            mTextSettingDescription.setText(key);
+            mTextSettingDescription.setVisibility(View.VISIBLE);
+        } else {
+            mTextSettingDescription.setVisibility(View.GONE);
+        }
     }
 
     @Override

src/android/app/src/main/java/org/citra/citra_android/ui/settings/viewholder/SingleChoiceViewHolder.java

@@ -30,7 +30,7 @@ public final class SingleChoiceViewHolder extends SettingViewHolder {
         mItem = item;
 
         mTextSettingName.setText(item.getNameId());
-
+        mTextSettingDescription.setVisibility(View.VISIBLE);
         if (item.getDescriptionId() > 0) {
             mTextSettingDescription.setText(item.getDescriptionId());
         } else if (item instanceof SingleChoiceSetting) {
@@ -44,6 +44,8 @@ public final class SingleChoiceViewHolder extends SettingViewHolder {
                     mTextSettingDescription.setText(choices[i]);
                 }
             }
+        } else {
+            mTextSettingDescription.setVisibility(View.GONE);
         }
     }
 

src/android/app/src/main/java/org/citra/citra_android/ui/settings/viewholder/SliderViewHolder.java

@@ -32,6 +32,9 @@ public final class SliderViewHolder extends SettingViewHolder {
 
         if (item.getDescriptionId() > 0) {
             mTextSettingDescription.setText(item.getDescriptionId());
+            mTextSettingDescription.setVisibility(View.VISIBLE);
+        } else {
+            mTextSettingDescription.setVisibility(View.GONE);
         }
     }
 

src/android/app/src/main/java/org/citra/citra_android/ui/settings/viewholder/SubmenuViewHolder.java

@@ -32,6 +32,9 @@ public final class SubmenuViewHolder extends SettingViewHolder {
 
         if (item.getDescriptionId() > 0) {
             mTextSettingDescription.setText(item.getDescriptionId());
+            mTextSettingDescription.setVisibility(View.VISIBLE);
+        } else {
+            mTextSettingDescription.setVisibility(View.GONE);
         }
     }
 

src/android/app/src/main/res/layout/list_item_setting.xml

@@ -3,37 +3,39 @@
                 xmlns:tools="http://schemas.android.com/tools"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:minHeight="72dp"
                 android:background="?android:attr/selectableItemBackground"
+                android:clickable="true"
                 android:focusable="true"
-                android:clickable="true">
+                android:gravity="center_vertical"
+                android:minHeight="72dp"
+                android:paddingTop="@dimen/spacing_large"
+                android:paddingBottom="@dimen/spacing_large">
 
     <TextView
+        android:id="@+id/text_setting_name"
+        style="@style/TextAppearance.AppCompat.Headline"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
-        style="@style/TextAppearance.AppCompat.Headline"
-        tools:text="Setting Name"
-        android:layout_alignParentEnd="true"
         android:layout_alignParentStart="true"
         android:layout_alignParentTop="true"
+        android:layout_alignParentEnd="true"
         android:layout_marginStart="@dimen/spacing_large"
         android:layout_marginEnd="@dimen/spacing_large"
-        android:layout_marginTop="@dimen/spacing_large"
+        android:textSize="16sp"
-        android:id="@+id/text_setting_name"
+        tools:text="Setting Name" />
-        android:textSize="16sp"/>
 
     <TextView
+        android:id="@+id/text_setting_description"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        tools:text="@string/overclock_enable_description"
-        android:layout_alignParentEnd="true"
-        android:layout_alignParentStart="true"
-        android:layout_marginStart="@dimen/spacing_large"
-        android:layout_marginEnd="@dimen/spacing_large"
-        android:layout_marginBottom="@dimen/spacing_large"
-        android:layout_marginTop="@dimen/spacing_small"
-        android:id="@+id/text_setting_description"
         android:layout_below="@+id/text_setting_name"
-        android:layout_alignStart="@+id/text_setting_name"/>
+        android:layout_alignStart="@+id/text_setting_name"
+        android:layout_alignParentStart="true"
+        android:layout_alignParentEnd="true"
+        android:layout_marginStart="@dimen/spacing_large"
+        android:layout_marginTop="@dimen/spacing_small"
+        android:layout_marginEnd="@dimen/spacing_large"
+        android:visibility="visible"
+        tools:text="@string/app_disclaimer" />
 
 </RelativeLayout>

src/android/app/src/main/res/layout/list_item_settings_header.xml

@@ -5,14 +5,15 @@
              android:layout_height="48dp">
 
     <TextView
+        android:id="@+id/text_header_name"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:id="@+id/text_header_name"
+        android:layout_gravity="center_vertical"
-        tools:text="CPU Settings"
         android:layout_marginStart="@dimen/spacing_large"
         android:layout_marginBottom="@dimen/spacing_small"
+        android:layout_marginTop="@dimen/spacing_small"
         android:textColor="?android:colorAccent"
         android:textStyle="bold"
-        android:layout_gravity="left|bottom"/>
+        tools:text="CPU Settings" />
 
 </FrameLayout>