From 6e27ab6c916ee3fdc6b9524c4d47266a1f513e6f Mon Sep 17 00:00:00 2001
From: liushuyu <liushuyu011@gmail.com>
Date: Tue, 27 Feb 2024 17:15:55 -0700
Subject: [PATCH] server: fix the workaround logic issue

---
 src/server.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/server.ts b/src/server.ts
index 7534d6a..c0edc59 100644
--- a/src/server.ts
+++ b/src/server.ts
@@ -196,8 +196,8 @@ client.on('messageCreate', async (message) => {
       logger.error(`Unable to get the roles for ${message.author}`);
       return;
     }
-    const isAllowed = (cmd === 'case' && findArray(authorRoles, ['Admins', 'Moderators', 'Developer'])) ||
-      (cachedModule?.roles && findArray(authorRoles, cachedModule.roles));
+    const allowedRoles = cmd === 'case' ? ['Admins', 'Moderators', 'Developer'] : cachedModule?.roles;
+    const isAllowed = (!allowedRoles) || (allowedRoles && findArray(authorRoles, allowedRoles));
     if (!isAllowed) {
       await state.logChannel?.send(`${message.author.toString()} attempted to use admin command: ${message.content}`);
       logger.info(`${message.author.username} ${message.author} attempted to use admin command: ${message.content}`);