Citra-emu/dynarmic-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

emit_a64: get rid of useless NOP generation

Browse Source 
We don't actually patch anything in those locations beside a jump.
This commit is contained in:
BreadFish64 2020-04-20 15:11:25 -05:00 committed by SachinVin
parent 470be4f7dc
commit 73ee4b9480
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/A64/a32_emit_a64.cpp
View File

@ -879,7 +879,6 @@ void A32EmitA64::ReadMemory(A32EmitContext& ctx, IR::Inst* inst, const CodePtr c
ASSERT_MSG(false, "Invalid bit_size"); ASSERT_MSG(false, "Invalid bit_size");
break; break;
} }
code.EnsurePatchLocationSize(patch_location, 5);
fastmem_patch_info.emplace( fastmem_patch_info.emplace(
patch_location, patch_location,
@ -889,9 +888,7 @@ void A32EmitA64::ReadMemory(A32EmitContext& ctx, IR::Inst* inst, const CodePtr c
code.SetCodePtr(patch_location); code.SetCodePtr(patch_location);
FixupBranch thunk = code.B(); FixupBranch thunk = code.B();
u8* end_ptr = code.GetWritableCodePtr(); u8* end_ptr = code.GetWritableCodePtr();
code.EnsurePatchLocationSize(patch_location, 5); code.FlushIcacheSection(reinterpret_cast<const u8*>(patch_location), end_ptr);
code.FlushIcacheSection(reinterpret_cast<const u8*>(patch_location), code.GetCodePtr());
code.SetCodePtr(save_code_ptr); code.SetCodePtr(save_code_ptr);
code.SwitchToFarCode(); code.SwitchToFarCode();
code.SetJumpTarget(thunk); code.SetJumpTarget(thunk);
@ -994,7 +991,6 @@ void A32EmitA64::WriteMemory(A32EmitContext& ctx, IR::Inst* inst, const CodePtr
ASSERT_MSG(false, "Invalid bit_size"); ASSERT_MSG(false, "Invalid bit_size");
break; break;
} }
code.EnsurePatchLocationSize(patch_location, 5);
fastmem_patch_info.emplace( fastmem_patch_info.emplace(
patch_location, patch_location,
@ -1004,9 +1000,7 @@ void A32EmitA64::WriteMemory(A32EmitContext& ctx, IR::Inst* inst, const CodePtr
code.SetCodePtr(patch_location); code.SetCodePtr(patch_location);
FixupBranch thunk = code.B(); FixupBranch thunk = code.B();
u8* end_ptr = code.GetWritableCodePtr(); u8* end_ptr = code.GetWritableCodePtr();
code.EnsurePatchLocationSize(patch_location, 5); code.FlushIcacheSection(reinterpret_cast<const u8*>(patch_location), end_ptr);
code.FlushIcacheSection(reinterpret_cast<const u8*>(patch_location), code.GetCodePtr());
code.SetCodePtr(save_code_ptr); code.SetCodePtr(save_code_ptr);
code.SwitchToFarCode(); code.SwitchToFarCode();
code.SetJumpTarget(thunk); code.SetJumpTarget(thunk);