From 08cd3f0385d816969f674171efbc90e8bf5f50cf Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 1 May 2019 23:54:19 -0400 Subject: [PATCH] frontend/ir/ir_emitter: Apply const to locals where applicable Makes const usage consistent with all other functions in the source file. --- src/frontend/ir/ir_emitter.cpp | 92 +++++++++++++++++----------------- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/src/frontend/ir/ir_emitter.cpp b/src/frontend/ir/ir_emitter.cpp index 9ba67ef1..1da60f94 100644 --- a/src/frontend/ir/ir_emitter.cpp +++ b/src/frontend/ir/ir_emitter.cpp @@ -47,8 +47,8 @@ U32 IREmitter::LeastSignificantWord(const U64& value) { } ResultAndCarry IREmitter::MostSignificantWord(const U64& value) { - auto result = Inst(Opcode::MostSignificantWord, value); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto result = Inst(Opcode::MostSignificantWord, value); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); return {result, carry_out}; } @@ -124,32 +124,32 @@ NZCV IREmitter::NZCVFrom(const Value& value) { } ResultAndCarry IREmitter::LogicalShiftLeft(const U32& value_in, const U8& shift_amount, const U1& carry_in) { - auto result = Inst(Opcode::LogicalShiftLeft32, value_in, shift_amount, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto result = Inst(Opcode::LogicalShiftLeft32, value_in, shift_amount, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); return {result, carry_out}; } ResultAndCarry IREmitter::LogicalShiftRight(const U32& value_in, const U8& shift_amount, const U1& carry_in) { - auto result = Inst(Opcode::LogicalShiftRight32, value_in, shift_amount, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto result = Inst(Opcode::LogicalShiftRight32, value_in, shift_amount, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); return {result, carry_out}; } ResultAndCarry IREmitter::ArithmeticShiftRight(const U32& value_in, const U8& shift_amount, const U1& carry_in) { - auto result = Inst(Opcode::ArithmeticShiftRight32, value_in, shift_amount, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto result = Inst(Opcode::ArithmeticShiftRight32, value_in, shift_amount, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); return {result, carry_out}; } ResultAndCarry IREmitter::RotateRight(const U32& value_in, const U8& shift_amount, const U1& carry_in) { - auto result = Inst(Opcode::RotateRight32, value_in, shift_amount, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto result = Inst(Opcode::RotateRight32, value_in, shift_amount, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); return {result, carry_out}; } ResultAndCarry IREmitter::RotateRightExtended(const U32& value_in, const U1& carry_in) { - auto result = Inst(Opcode::RotateRightExtended, value_in, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto result = Inst(Opcode::RotateRightExtended, value_in, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); return {result, carry_out}; } @@ -202,9 +202,9 @@ U32U64 IREmitter::RotateRight(const U32U64& value_in, const U8& shift_amount) { } ResultAndCarryAndOverflow IREmitter::AddWithCarry(const U32& a, const U32& b, const U1& carry_in) { - auto result = Inst(Opcode::Add32, a, b, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); - auto overflow = Inst(Opcode::GetOverflowFromOp, result); + const auto result = Inst(Opcode::Add32, a, b, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto overflow = Inst(Opcode::GetOverflowFromOp, result); return {result, carry_out, overflow}; } @@ -228,9 +228,9 @@ U32U64 IREmitter::Add(const U32U64& a, const U32U64& b) { ResultAndCarryAndOverflow IREmitter::SubWithCarry(const U32& a, const U32& b, const U1& carry_in) { // This is equivalent to AddWithCarry(a, Not(b), carry_in). - auto result = Inst(Opcode::Sub32, a, b, carry_in); - auto carry_out = Inst(Opcode::GetCarryFromOp, result); - auto overflow = Inst(Opcode::GetOverflowFromOp, result); + const auto result = Inst(Opcode::Sub32, a, b, carry_in); + const auto carry_out = Inst(Opcode::GetCarryFromOp, result); + const auto overflow = Inst(Opcode::GetOverflowFromOp, result); return {result, carry_out, overflow}; } @@ -541,8 +541,8 @@ ResultAndOverflow IREmitter::SignedSaturatedSub(const UAny& a, const UAny& ResultAndOverflow IREmitter::SignedSaturation(const U32& a, size_t bit_size_to_saturate_to) { ASSERT(bit_size_to_saturate_to >= 1 && bit_size_to_saturate_to <= 32); - auto result = Inst(Opcode::SignedSaturation, a, Imm8(static_cast(bit_size_to_saturate_to))); - auto overflow = Inst(Opcode::GetOverflowFromOp, result); + const auto result = Inst(Opcode::SignedSaturation, a, Imm8(static_cast(bit_size_to_saturate_to))); + const auto overflow = Inst(Opcode::GetOverflowFromOp, result); return {result, overflow}; } @@ -588,80 +588,80 @@ ResultAndOverflow IREmitter::UnsignedSaturatedSub(const UAny& a, const UAn ResultAndOverflow IREmitter::UnsignedSaturation(const U32& a, size_t bit_size_to_saturate_to) { ASSERT(bit_size_to_saturate_to <= 31); - auto result = Inst(Opcode::UnsignedSaturation, a, Imm8(static_cast(bit_size_to_saturate_to))); - auto overflow = Inst(Opcode::GetOverflowFromOp, result); + const auto result = Inst(Opcode::UnsignedSaturation, a, Imm8(static_cast(bit_size_to_saturate_to))); + const auto overflow = Inst(Opcode::GetOverflowFromOp, result); return {result, overflow}; } ResultAndGE IREmitter::PackedAddU8(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedAddU8, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedAddU8, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedAddS8(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedAddS8, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedAddS8, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedAddU16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedAddU16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedAddU16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedAddS16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedAddS16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedAddS16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedSubU8(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedSubU8, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedSubU8, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedSubS8(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedSubS8, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedSubS8, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedSubU16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedSubU16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedSubU16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedSubS16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedSubS16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedSubS16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedAddSubU16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedAddSubU16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedAddSubU16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedAddSubS16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedAddSubS16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedAddSubS16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedSubAddU16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedSubAddU16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedSubAddU16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; } ResultAndGE IREmitter::PackedSubAddS16(const U32& a, const U32& b) { - auto result = Inst(Opcode::PackedSubAddS16, a, b); - auto ge = Inst(Opcode::GetGEFromOp, result); + const auto result = Inst(Opcode::PackedSubAddS16, a, b); + const auto ge = Inst(Opcode::GetGEFromOp, result); return {result, ge}; }