From f1396adce989b8c459736bdb5506c6e78d738c91 Mon Sep 17 00:00:00 2001 From: archshift Date: Wed, 10 Dec 2014 18:29:40 -0800 Subject: [PATCH] Added scope_exit, which is very helpful for handling situations where the test exits early. --- source/scope_exit.h | 37 +++++++++++++++++++++++++++++++++++++ source/tests/fs/fs_sdmc.cpp | 7 ++++--- 2 files changed, 41 insertions(+), 3 deletions(-) create mode 100644 source/scope_exit.h diff --git a/source/scope_exit.h b/source/scope_exit.h new file mode 100644 index 0000000..1d3e593 --- /dev/null +++ b/source/scope_exit.h @@ -0,0 +1,37 @@ +// Copyright 2014 Citra Emulator Project +// Licensed under GPLv2+ +// Refer to the license.txt file included. + +#pragma once + +namespace detail { + template + struct ScopeExitHelper { + explicit ScopeExitHelper(Func&& func) : func(std::move(func)) {} + ~ScopeExitHelper() { func(); } + + Func func; + }; + + template + ScopeExitHelper ScopeExit(Func&& func) { return ScopeExitHelper(std::move(func)); } +} + +/** + * This macro allows you to conveniently specify a block of code that will run on scope exit. Handy + * for doing ad-hoc clean-up tasks in a function with multiple returns. + * + * Example usage: + * \code + * const int saved_val = g_foo; + * g_foo = 55; + * SCOPE_EXIT({ g_foo = saved_val; }); + * + * if (Bar()) { + * return 0; + * } else { + * return 20; + * } + * \endcode + */ +#define SCOPE_EXIT(body) auto scope_exit_helper_##__LINE__ = detail::ScopeExit([&]() body) diff --git a/source/tests/fs/fs_sdmc.cpp b/source/tests/fs/fs_sdmc.cpp index 9de2159..dfcfccc 100644 --- a/source/tests/fs/fs_sdmc.cpp +++ b/source/tests/fs/fs_sdmc.cpp @@ -70,6 +70,10 @@ static bool TestFileWriteRead(FS_archive sdmcArchive) // Create file FSUSER_OpenFile(NULL, &fileHandle, sdmcArchive, filePath, FS_OPEN_CREATE | FS_OPEN_WRITE, 0); + SCOPE_EXIT({ // Close and delete file no matter what happens + FSFILE_Close(fileHandle); + FSUSER_DeleteFile(NULL, sdmcArchive, filePath); + }); // Write to file SoftAssert(FSFILE_Write(fileHandle, &bytesWritten, 0, stringWritten, strlen(stringWritten)+1, FS_WRITE_FLUSH) == 0); @@ -87,9 +91,6 @@ static bool TestFileWriteRead(FS_archive sdmcArchive) // Verify string contents SoftAssert(strcmp(stringRead.get(), stringWritten) == 0); - FSFILE_Close(fileHandle); - FSUSER_DeleteFile(NULL, sdmcArchive, filePath); - return true; }