From 0a49d03589c15742057c70d51d01e09351ba36f7 Mon Sep 17 00:00:00 2001
From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com>
Date: Tue, 30 Jul 2024 11:45:07 +0200
Subject: [PATCH] VstdLib: light optimizations for CUniformRandomStream

Use Min instead of an inline check, this generates better assembly code. Also made all the used defines a float to avoid having to cast each time since we aren't working with double precision floating points here.
---
 src/vstdlib/random.cpp | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/src/vstdlib/random.cpp b/src/vstdlib/random.cpp
index b1f9aa66..4ab584e7 100644
--- a/src/vstdlib/random.cpp
+++ b/src/vstdlib/random.cpp
@@ -20,9 +20,9 @@
 
 // fran1 -- return a random floating-point number on the interval [0,1)
 //
-#define AM (1.0/IM)
-#define EPS 1.2e-7
-#define RNMX (1.0-EPS)
+#define AM (1.0f/IM)
+#define EPS 1.2e-7f
+#define RNMX (1.0f-EPS)
 
 //-----------------------------------------------------------------------------
 // globals
@@ -118,22 +118,14 @@ int CUniformRandomStream::GenerateRandomNumber()
 float CUniformRandomStream::RandomFloat(const float flLow, const float flHigh)
 {
 	// float in [0,1)
-	float fl = float(AM) * GenerateRandomNumber();
-	if (fl > RNMX)
-	{
-		fl = float(RNMX);
-	}
+	const float fl = Min(AM * GenerateRandomNumber(), RNMX);
 	return (fl * (flHigh - flLow)) + flLow; // float in [low,high)
 }
 
 float CUniformRandomStream::RandomFloatExp(const float flMinVal, const float flMaxVal, const float flExponent)
 {
 	// float in [0,1)
-	float fl = float(AM) * GenerateRandomNumber();
-	if (fl > RNMX)
-	{
-		fl = float(RNMX);
-	}
+	float fl = Min(AM * GenerateRandomNumber(), RNMX);
 	if (flExponent != 1.0f)
 	{
 		fl = powf(fl, flExponent);