R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Common: improve SVC_SetClassVar member variable naming

Browse Source 
This netmessage interfaces with the settings kay values system.
This commit is contained in:
Kawe Mazidjatari 2025-02-02 14:34:57 +01:00
parent 452c226316
commit 0f17987599
2 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/common/netmessages.cpp
View File

@ -70,24 +70,24 @@ bool SVC_UserMessage::ProcessImpl()
/////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////
bool SVC_SetClassVar::ReadFromBuffer(bf_read* buffer) bool SVC_SetClassVar::ReadFromBuffer(bf_read* buffer)
{ {
const bool set = buffer->ReadString(m_szSetting, sizeof(m_szSetting)); const bool key = buffer->ReadString(m_szKey, sizeof(m_szKey));
const bool var = buffer->ReadString(m_szVariable, sizeof(m_szVariable)); const bool val = buffer->ReadString(m_szValue, sizeof(m_szValue));
return set && var; return key && val;
} }
bool SVC_SetClassVar::WriteToBuffer(bf_write* buffer) bool SVC_SetClassVar::WriteToBuffer(bf_write* buffer)
{ {
const bool set = buffer->WriteString(m_szSetting); const bool key = buffer->WriteString(m_szKey);
const bool var = buffer->WriteString(m_szVariable); const bool val = buffer->WriteString(m_szValue);
return set && var; return key && val;
} }
bool SVC_SetClassVar::Process(void) bool SVC_SetClassVar::Process(void)
{ {
const char* pArgs[3] = { const char* pArgs[3] = {
"_setClassVarClient", "_setClassVarClient",
m_szSetting, m_szKey,
m_szVariable m_szValue
}; };
CCommand command((int)V_ARRAYSIZE(pArgs), pArgs, cmd_source_t::kCommandSrcCode); CCommand command((int)V_ARRAYSIZE(pArgs), pArgs, cmd_source_t::kCommandSrcCode);

16
src/common/netmessages.h
View File

@ -464,13 +464,13 @@ class SVC_SetClassVar : public CNetMessage
{ {
public: public:
SVC_SetClassVar() = default; SVC_SetClassVar() = default;
SVC_SetClassVar(const char* setting, const char* var) SVC_SetClassVar(const char* key, const char* value)
{ {
V_strncpy(m_szSetting, setting, sizeof(m_szSetting)); V_strncpy(m_szKey, key, sizeof(m_szKey));
V_strncpy(m_szVariable, var, sizeof(m_szVariable)); V_strncpy(m_szValue, value, sizeof(m_szValue));
m_szSetting[sizeof(m_szSetting) - 1] = '\0'; m_szKey[sizeof(m_szKey) - 1] = '\0';
m_szVariable[sizeof(m_szVariable) - 1] = '\0'; m_szValue[sizeof(m_szValue) - 1] = '\0';
m_nGroup = 2; // must be set to 2 to avoid being copied into replay buffer m_nGroup = 2; // must be set to 2 to avoid being copied into replay buffer
} }
@ -486,15 +486,15 @@ public:
virtual const char* ToString(void) const virtual const char* ToString(void) const
{ {
static char szBuf[4096]; static char szBuf[4096];
V_snprintf(szBuf, sizeof(szBuf), "%s: setting \"%s\", variable \"%s\"", this->GetName(), m_szSetting, m_szVariable); V_snprintf(szBuf, sizeof(szBuf), "%s: key \"%s\", value \"%s\"", this->GetName(), m_szKey, m_szValue);
return szBuf; return szBuf;
}; };
virtual size_t GetSize(void) const { return sizeof(SVC_SetClassVar); } virtual size_t GetSize(void) const { return sizeof(SVC_SetClassVar); }
char m_szSetting[128]; char m_szKey[128];
char m_szVariable[128]; char m_szValue[128];
}; };
/////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////