R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

utility: fix STL string formatter bug

Browse Source 
Must reserve a buf size of len+1 before resizing it, else we are 1 byte too short when copying the entire string. Also just clear when 0.
This commit is contained in:
Kawe Mazidjatari 2024-02-06 14:36:01 +01:00
parent 60a3cee531
commit 115b8e214a
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
r5dev/tier0/utility.cpp
View File

@ -1086,14 +1086,20 @@ string FormatV(const char* szFormat, va_list args)
assert(iLen >= 0);
string result;
if (iLen < 0)
if (iLen <= 0)
{
result.clear();
}
else
{
// NOTE: reserve enough buffer size for the string + the terminating
// NULL character, then resize it to just the string len so we don't
// count the NULL character in the string's size (i.e. when calling
// string::size()).
result.reserve(iLen+1);
result.resize(iLen);
std::vsnprintf(&result[0], iLen+sizeof(char), szFormat, args);
std::vsnprintf(&result[0], iLen+1, szFormat, args);
}
return result;