R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix using incorrect member as bounds for looping exporteds

Browse Source 
Fixes a crasher on certain modules as it could read oob; must use 'NumberOfNames' to iterate over export names.
This commit is contained in:
Kawe Mazidjatari 2023-07-23 20:02:12 +02:00
parent af81954b7f
commit 2b05edd374
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
r5dev/tier0/module_statics.cpp
View File

@ -120,7 +120,7 @@ CMemory CModule::GetExportedSymbol(QWORD pModuleBase, const char* szSymbolName)
if (!pAddressOfOrdinals) if (!pAddressOfOrdinals)
return nullptr; return nullptr;
for (DWORD i = 0; i < pImageExportDirectory->NumberOfFunctions; i++) for (DWORD i = 0; i < pImageExportDirectory->NumberOfNames; i++)
{ {
// Get virtual relative Address of the function name, // Get virtual relative Address of the function name,
// then add module base Address to get the actual location. // then add module base Address to get the actual location.