R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Banlist writing optimizations

Browse Source 
* Only write if there is something to write.
* Don't write each iteration, write after the loops are finished.
This commit is contained in:
Kawe Mazidjatari 2022-08-28 00:11:33 +02:00
parent 532b4125d5
commit 38c94eda27
2 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
r5dev/networksystem/bansystem.cpp
View File

@ -66,6 +66,11 @@ void CBanSystem::Load(void)
m_vBanList.push_back(std::make_pair(svIpAddress, nOriginID));
}
}
else
{
// File no longer accessible, assume they want all bans dropped.
m_vBanList.clear();
}
}
//-----------------------------------------------------------------------------

34
r5dev/vstdlib/callback.cpp
View File

@ -202,6 +202,8 @@ void Host_Ban_f(const CCommand& args)
return;
}
bool bSave = false;
for (int i = 0; i < MAX_PLAYERS; i++)
{
if (CClient* pClient = g_pClient->GetClient(i))
@ -212,14 +214,21 @@ void Host_Ban_f(const CCommand& args)
{
if (strcmp(args.Arg(1), pNetChan->GetName()) == NULL) // Our wanted name?
{
g_pBanSystem->AddEntry(pNetChan->GetAddress(), pClient->GetOriginID());
g_pBanSystem->Save();
if (g_pBanSystem->AddEntry(pNetChan->GetAddress(), pClient->GetOriginID() && !bSave))
{
bSave = true;
}
NET_DisconnectClient(pClient, i, "Banned from server", 0, true);
}
}
}
}
}
if (bSave)
{
g_pBanSystem->Save();
}
}
/*
@ -230,13 +239,13 @@ Host_BanID_f
void Host_BanID_f(const CCommand& args)
{
if (args.ArgC() < 2)
{
return;
}
try
{
bool bOnlyDigits = args.HasOnlyDigits(1);
bool bSave = false;
for (int i = 0; i < MAX_PLAYERS; i++)
{
CClient* pClient = g_pClient->GetClient(i);
@ -254,35 +263,36 @@ void Host_BanID_f(const CCommand& args)
{
uint64_t nOriginID = pClient->GetOriginID();
if (nOriginID != nTargetID)
{
continue;
}
}
else // If its not try by handle.
{
uint64_t nClientID = static_cast<uint64_t>(pClient->GetHandle());
if (nClientID != nTargetID)
{
continue;
}
}
g_pBanSystem->AddEntry(pNetChan->GetAddress(), pClient->GetOriginID());
if (g_pBanSystem->AddEntry(pNetChan->GetAddress(), pClient->GetOriginID()) && !bSave)
bSave = true;
g_pBanSystem->Save();
NET_DisconnectClient(pClient, i, "Banned from server", 0, true);
}
else
{
if (strcmp(args.Arg(1), pNetChan->GetAddress()) != NULL)
{
continue;
}
g_pBanSystem->AddEntry(pNetChan->GetAddress(), pClient->GetOriginID());
if (g_pBanSystem->AddEntry(pNetChan->GetAddress(), pClient->GetOriginID()) && !bSave)
bSave = true;
g_pBanSystem->Save();
NET_DisconnectClient(pClient, i, "Banned from server", 0, true);
}
}
if (bSave)
g_pBanSystem->Save();
}
catch (std::exception& e)
{