R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Temporarily fix convar value assignment bug in 'CRConServer::Execute()'

Browse Source 
Command string buffer contains "sv_cheats" and value buffer contains "sv_cheats 1". Ideally value buffer only contains "1", and we just concatenate to "sv_cheats 1" for 'Cmd_Dispatch()' to avoid confusion on the netconsole's programmer side. This will be refactored in the future.
This commit is contained in:
Kawe Mazidjatari 2023-08-05 20:29:07 +02:00
parent 2d6a1c79ac
commit 3ca092f598
1 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
r5dev/engine/server/sv_rcon.cpp
View File

@ -454,7 +454,9 @@ bool CRConServer::ProcessMessage(const char* pMsgBuf, const int nMsgLen)
//-----------------------------------------------------------------------------
void CRConServer::Execute(const cl_rcon::request& request) const
{
const char* pCommandString = request.requestmsg().c_str();
const string& commandString = request.requestmsg().c_str();
const char* const pCommandString = commandString.c_str();
ConCommandBase* pCommandBase = g_pCVar->FindCommandBase(pCommandString);
if (!pCommandBase)
@ -463,13 +465,29 @@ void CRConServer::Execute(const cl_rcon::request& request) const
return;
}
const bool isCommand = pCommandBase->IsCommand();
const char* pValueString = request.requestval().c_str();
const char* const pValueString = request.requestval().c_str();
if (!isCommand)
if (!pCommandBase->IsCommand())
{
// Here we want to skip over the command string in the value buffer.
// So if we got 'sv_cheats 1' in our value buffer, we want to skip
// over 'sv_cheats ', so that we are pointing directly to the value.
const char* pFound = V_strstr(pValueString, pCommandString);
const char* pValue = nullptr;
if (pFound)
{
pValue = pFound + commandString.length();
// Skip any leading space characters.
while (*pValue == ' ')
{
++pValue;
}
}
ConVar* pConVar = reinterpret_cast<ConVar*>(pCommandBase);
pConVar->SetValue(pValueString);
pConVar->SetValue(pValue ? pValue : pValueString);
}
else // Invoke command callback directly.
{