R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only run duplicate checks in debug

Browse Source 
Duplicate checks are only performed in debug builds, if a duplicate is encountered, a bug in code has been found and has to be solved (do not call REGISTER from headers for example).
This commit is contained in:
Kawe Mazidjatari 2023-01-25 19:22:05 +01:00
parent 9ea06aa65d
commit 532ada48e0
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
r5dev/thirdparty/detours/include/idetour.h vendored
View File

@ -33,10 +33,13 @@ inline std::vector<IDetour*> vDetour;
inline std::unordered_set<IDetour*> sDetour;
inline std::size_t AddDetour(IDetour* pDetour, const char* pszName)
{
#ifdef _DEBUG
IDetour* pVFTable = reinterpret_cast<IDetour**>(pDetour)[0];
auto p = sDetour.insert(pVFTable); // Only register if VFTable isn't already registered.
assert(p.second); // Code bug: duplicate registration!!! (called 'REGISTER(...)' from a header file?).
p.second ? vDetour.push_back(pDetour) : delete pDetour;
#endif // DEBUG
return vDetour.size();
}