From 56aba36b8ccf667b6de04f7e487b1c76b1613059 Mon Sep 17 00:00:00 2001 From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com> Date: Sun, 2 Feb 2025 14:58:41 +0100 Subject: [PATCH] Codecs: disable Miles bank patch validation The validation code uses internal structures of the Miles Sound System which is different for each version of the sound engine versions we support, which makes switching banks impossible without recompiling the SDK. The bank patches rarely fail, but if we decide to keep this we should seek for an alternative approach i.e. using the DLL interfaces directly. --- src/codecs/miles/miles_impl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/codecs/miles/miles_impl.cpp b/src/codecs/miles/miles_impl.cpp index 8559b9d8..c1b04c14 100644 --- a/src/codecs/miles/miles_impl.cpp +++ b/src/codecs/miles/miles_impl.cpp @@ -117,6 +117,6 @@ void MilesCore::Detour(const bool bAttach) const DetourSetup(&v_AIL_LogFunc, &AIL_LogFunc, bAttach); DetourSetup(&v_Miles_Initialize, &Miles_Initialize, bAttach); DetourSetup(&v_MilesQueueEventRun, &MilesQueueEventRun, bAttach); - DetourSetup(&v_MilesBankPatch, &MilesBankPatch, bAttach); + //DetourSetup(&v_MilesBankPatch, &MilesBankPatch, bAttach); DetourSetup(&v_CSOM_AddEventToQueue, &CSOM_AddEventToQueue, bAttach); }