R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect ConVar string assignment in executable

Browse Source 
This ConVar's name was set to its helpstring. This patch solves it by assigning the name field to an existing string that makes sense, and moving the helpstring into the actual helpstring field. An additional instruction has been inserted to load the NULL string address into RAX, which required light instruction shifting. After performing this patch, the ConVar now could be ser in the console.
This commit is contained in:
Kawe Mazidjatari 2023-06-05 10:27:23 +02:00
parent 2ae8a74ad9
commit 70f89c1bd8
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
r5dev/resource/patch/r5apex.patch
View File

@ -51,6 +51,19 @@
0x1477876: 'FIELD_INTERVALFIELD_MODELINDEX\x00\x00' --> 'FIELD_INTERVAL\x00FIELD_MODELINDEX\x00';
0x1318C00: 0x0000000000 --> 0x7792474101; // Add new entry in 'g_FieldTypes', this entry points to the 'FIELD_MODELINDEX' string we separated from 'FIELD_INTERVAL'.
// This fixes a bug where the help string of a ConVar is set as the conVar name, which prevents you from
// setting it in the console due to the precense of space characters.
0x115EAE: "lea rax, ds:[0x141516578]" // Change ConVar name assignment from helpstring to "player_vehicle"
0x115EBC: "lea rax, ds:[0x141459F20]" // Change ConVar help string assignment from null string to the helpstring.
// This operation has been inserted within the function, all instructions past this one
// have been shifted.
0x115ECA: "lea rax, ds:[0x141324120]" // Load NULL_STRING back into rax to assign to usage string.
// Path below is exactly the same as above, but at a different address as this particular convar has
// 2 dynamic initializers.
0x15B8AE: "lea rax, ds:[0x141516578]"
0x15B8BC: "lea rax, ds:[0x141459F20]"
0x15B8CA: "lea rax, ds:[0x141324120]"
// In 'CInput::JoyStickApplyMovement' an extraneous 'fmin' clamp is performed on the frame time. BinDiff revealed that this was no longer performed on
// the 'Season 9.1 Genesis' executable. Further testing revealed that patching out just this clamp fixes the controller view stick problems when usercmd's
// get dropped in CL_Move.