R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optimize RCON

Browse Source 
Don't run CheckForBan each iteration if no failed attempts are made
This commit is contained in:
Kawe Mazidjatari 2022-05-13 21:41:03 +02:00
parent ffa6eb55e8
commit 77303e44b5
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
r5dev/common/igameserverdata.h
View File

@ -33,6 +33,7 @@ public:
SocketHandle_t m_hSocket {};
int m_nCharsInCommandBuffer {};
char m_pszInputCommandBuffer[MAX_NETCONSOLE_INPUT_LEN] {};
bool m_bValidated {}; // Revalidates netconsole if false.
bool m_bAuthorized {}; // Set to true after netconsole successfully authed.
bool m_bInputOnly {}; // If set, don't send spew to this net console.
int m_nFailedAttempts {}; // Num failed authentication attempts.

8
r5dev/engine/sv_rcon.cpp
View File

@ -260,6 +260,7 @@ void CRConServer::Authenticate(const cl_rcon::request& cl_request, CConnectedNet
::send(pData->m_hSocket, svWrongPass.c_str(), static_cast<int>(svWrongPass.size()), MSG_NOSIGNAL);
pData->m_bAuthorized = false;
pData->m_bValidated = false;
pData->m_nFailedAttempts++;
}
}
@ -338,6 +339,7 @@ void CRConServer::ProcessMessage(const cl_rcon::request& cl_request)
std::string svMessage = this->Serialize(s_pszNoAuthMessage, "", sv_rcon::response_t::SERVERDATA_RESPONSE_AUTH);
::send(pData->m_hSocket, svMessage.c_str(), static_cast<int>(svMessage.size()), MSG_NOSIGNAL);
pData->m_bValidated = false;
pData->m_nIgnoredMessage++;
return;
}
@ -397,6 +399,12 @@ void CRConServer::Execute(const cl_rcon::request& cl_request) const
//-----------------------------------------------------------------------------
bool CRConServer::CheckForBan(CConnectedNetConsoleData* pData)
{
if (pData->m_bValidated)
{
return false;
}
pData->m_bValidated = true;
CNetAdr2 netAdr2 = m_pSocket->GetAcceptedSocketAddress(m_nConnIndex);
// Check if IP is in the ban vector.