R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

/W4: Use 'constexpr' to evaluate branch at compile time

Browse Source 
Fixes many compiler warnings.
This commit is contained in:
Kawe Mazidjatari 2023-04-02 11:19:23 +02:00
parent 0aa62890bb
commit 7de717d47c
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
r5dev/common/pseudodefs.h
View File

@ -241,7 +241,7 @@ template<class T> T __ROL__(T value, int count)
{
count %= nbits;
T high = value >> (nbits - count);
if ( T(-1) < 0 ) // signed value
if constexpr ( T(-1) < 0 ) // signed value
high &= ~((T(-1) << count));
value <<= count;
value |= high;

2
r5dev/tier0/threadtools.h
View File

@ -136,7 +136,7 @@ public:
bool AssignIf(T conditionValue, T newValue)
{
if (sizeof(T) == sizeof(int32))
if constexpr(sizeof(T) == sizeof(int32))
return ThreadInterlockedAssignIf((LONG*)&m_value, (int32)newValue, (int32)conditionValue);
else
return ThreadInterlockedAssignIf64((int64*)&m_value, (int64)newValue, (int64)conditionValue);

2
r5dev/tier1/strtools.cpp
View File

@ -592,7 +592,7 @@ bool V_IsAbsolutePath(const char* pStr)
bool bIsAbsolute = (pStr[0] && pStr[1] == ':') || pStr[0] == '/' || pStr[0] == '\\';
#endif
if (IsX360() && !bIsAbsolute)
if constexpr (IsX360() && !bIsAbsolute)
{
bIsAbsolute = (V_stristr(pStr, ":") != NULL);
}

6
r5dev/tier1/utlbuffer.h
View File

@ -214,7 +214,7 @@ public:
FORCEINLINE void ActivateByteSwappingIfBigEndian(void)
{
if ((IsX360() || IsPS3()))
if constexpr ((IsX360() || IsPS3()))
ActivateByteSwapping(true);
}
@ -714,7 +714,7 @@ inline void CUtlBuffer::GetTypeBin< float >(float& dest)
if (CheckGet(sizeof(float)))
{
uintptr_t pData = (uintptr_t)PeekGet();
if ((IsX360() || IsPS3()) && (pData & 0x03))
if constexpr ((IsX360() || IsPS3()) && (pData & 0x03))
{
// handle unaligned read
((unsigned char*)&dest)[0] = ((unsigned char*)pData)[0];
@ -745,7 +745,7 @@ inline void CUtlBuffer::GetTypeBin< double >(double& dest)
if (CheckGet(sizeof(double)))
{
uintptr_t pData = (uintptr_t)PeekGet();
if ((IsX360() || IsPS3()) && (pData & 0x07))
if constexpr ((IsX360() || IsPS3()) && (pData & 0x07))
{
// handle unaligned read
((unsigned char*)&dest)[0] = ((unsigned char*)pData)[0];

2
r5dev/tier2/meshutils.cpp
View File

@ -44,7 +44,7 @@ void GenerateQuadIndexBuffer(unsigned short* pIndices, int nIndexCount, int nFir
for (i = 0; i < numQuads; ++i)
{
// Have to deal with endian-ness
if (IsX360() || IsPS3())
if constexpr (IsX360() || IsPS3())
{
// this avoids compiler write reodering and prevents the write-combined out-of-order penalty
// _WriteBarrier won't compile here, and volatile is ignored