R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Netconsole: fix race condition caused by misplaced mutex

Browse Source 
Mutex should be locked before IsConnected(), as IsConnected() accesses CSocketCreator which checks a vector (not thread safe), lock the mutex in the correct place.
This commit is contained in:
Kawe Mazidjatari 2024-02-22 02:00:09 +01:00
parent 1674200764
commit 869741b3b3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
r5dev/netconsole/netconsole.cpp
View File

@ -278,10 +278,10 @@ bool CNetCon::RunFrame(void)
{
if (IsInitialized())
{
std::lock_guard<std::mutex> l(m_Mutex);
if (IsConnected())
{
std::lock_guard<std::mutex> l(m_Mutex);
CConnectedNetConsoleData& pData = GetSocketCreator()->GetAcceptedSocketData(0);
Recv(pData);
}