From 978f108526cebb078dfe82831f7f203ee77566db Mon Sep 17 00:00:00 2001 From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com> Date: Sun, 2 Apr 2023 14:58:02 +0200 Subject: [PATCH] /W4: Fix incorrect type cast Values passed to functions from '' must be representable as unsigned chars to avoid undefined behavior. --- r5dev/public/utility/utility.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/r5dev/public/utility/utility.cpp b/r5dev/public/utility/utility.cpp index e3158416..9fc7619d 100644 --- a/r5dev/public/utility/utility.cpp +++ b/r5dev/public/utility/utility.cpp @@ -243,8 +243,8 @@ char* StripQuotes(const char* pInBuffer, char* pOutBuffer, int nOutBufferSize) // For finding a partial string within input (case insensitive). bool HasPartial(const string& svInput, const string& svPartial) { - auto it = std::search( svInput.begin(), svInput.end(), - svPartial.begin(), svPartial.end(), [](char ci, char cp) + auto it = std::search(svInput.begin(), svInput.end(), + svPartial.begin(), svPartial.end(), [](unsigned char ci, unsigned char cp) { return std::toupper(ci) == std::toupper(cp); }