R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optimize C2S_CONNECT vuln fix

Browse Source 
Save 2 bytes from segment padding by performing zero test at original address followed by the long jump to patch, there were 5 bytes, zero test only requires 2, thus only 3 bytes were nopped with these changes.
This commit is contained in:
Kawe Mazidjatari 2023-05-31 21:25:16 +02:00
parent 619bbd161c
commit a061f7dd00
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
r5dev/resource/patch/r5apex.patch
View File

@ -68,10 +68,17 @@
// This fixes a vulnerability in which the index field in the NET_SetConVar message // This fixes a vulnerability in which the index field in the NET_SetConVar message
// could be used to read outside the static userinfo cvar string array. // could be used to read outside the static userinfo cvar string array.
0x030DD29: "jmp 0x1412950E3" // Jump to code cave (alignment padding at end of executable segment). 0x030DD2B: "jmp 0x1412950E3" // Jump to code cave (alignment padding at end of executable segment).
0x12944E3: "test eax, eax" // Existing NULL check, moved here due to overwrite caused by long jmp. // The instruction prior to the jump above performs a 'test' on the eax register.
0x12944E5: "je 0x1412950F0" // Conditional jump to rebuild of overwritten instruction. // If the zero flag is set, it jumps to the rebuild of overwritten instructions
0x12944E7: "cmp eax, 0x28" // Check if array index does NOT exceed size; max = 0x27 (this check was missing). // caused by the long jmp to code cave.
0x12944EA: "jb 0x14030E951" // Conditional jump to original code that indexes into userinfo cvar string array. 0x12944E3: "je 0x1412950EE"
0x12944F0: "mov r8d, 0x104" // Rebuid of overwritten instruction caused by long jump to code cave. // This check was missing causing OOB reads! String array size is 0x27,
0x12944F6: "jmp 0x14030E933" // Jump to original code past the user info cvar array indexing. // so only index into it if its within bounds..
0x12944E5: "cmp eax, 0x28"
0x12944E8: "jb 0x14030E951"
// The following is rebuild as the long jump overwrote it,
// basically perform what was overwritten and jump back to
// original code...
0x12944EE: "mov r8d, 0x104"
0x12944F4: "jmp 0x14030E933"