From a7158d088182abf45bc5bb3c98342d8048878c63 Mon Sep 17 00:00:00 2001
From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com>
Date: Sat, 1 Apr 2023 21:42:34 +0200
Subject: [PATCH] CConsole::AddLog optimizations

Use FormatV to format the string, and use the move constructor to move it into the conlog structure.
---
 r5dev/gameui/IConsole.cpp | 12 ++++++------
 r5dev/gameui/IConsole.h   |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/r5dev/gameui/IConsole.cpp b/r5dev/gameui/IConsole.cpp
index 061fbed8..261dd0fb 100644
--- a/r5dev/gameui/IConsole.cpp
+++ b/r5dev/gameui/IConsole.cpp
@@ -1049,16 +1049,16 @@ void CConsole::AddLog(const ConLog_t& conLog)
 //          *fmt - 
 //          ... - 
 //-----------------------------------------------------------------------------
-void CConsole::AddLog(const ImVec4& color, const char* fmt, ...) IM_FMTARGS(2)
+void CConsole::AddLog(const ImVec4& color, const char* fmt, ...) /*IM_FMTARGS(2)*/
 {
-    char buf[4096];
-    va_list args{};
+    string result;
+    va_list args;
+
     va_start(args, fmt);
-    vsnprintf(buf, IM_ARRAYSIZE(buf), fmt, args);
-    buf[IM_ARRAYSIZE(buf) - 1] = 0;
+    result = FormatV(fmt, args);
     va_end(args);
 
-    m_Logger.InsertText(ConLog_t(buf, color));
+    m_Logger.InsertText(ConLog_t(result, color));
 }
 
 //-----------------------------------------------------------------------------
diff --git a/r5dev/gameui/IConsole.h b/r5dev/gameui/IConsole.h
index 4b7bfeae..04cada0b 100644
--- a/r5dev/gameui/IConsole.h
+++ b/r5dev/gameui/IConsole.h
@@ -55,7 +55,7 @@ public:
     void ClearHistory(void);
 
 private: // Internal only.
-    void AddLog(const ImVec4& color, const char* fmt, ...) IM_FMTARGS(2);
+    void AddLog(const ImVec4& color, const char* fmt, ...) /*IM_FMTARGS(2)*/;
 
     ///////////////////////////////////////////////////////////////////////////
     virtual void SetStyleVar(void);