From acc81bf0141e0b875b76505deee899ce8d212a1b Mon Sep 17 00:00:00 2001
From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com>
Date: Thu, 24 Nov 2022 01:53:45 +0100
Subject: [PATCH] Fix KeyValues memory leak

'MemAllocSingleton()->Free()' does not call the object's destructor. Ideally we override the default memalloc system with that of the engine, but unlike other Valve Source games, Apex Legends is monolithic and does not export 'MemAllocSingleton()' from tier0. We could manually patch the executable to 'export' this, might need a code cave as this function got inlined practically everywhere.., but even then, this results in a circular import as we import the gamesdk from the exe, which might just work, but Windows 7 is usually a lot less tolerant in approaches like these.

We should explore this in the future.
---
 r5dev/vpc/keyvalues.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/r5dev/vpc/keyvalues.cpp b/r5dev/vpc/keyvalues.cpp
index 10bbadd0..9e01ead8 100644
--- a/r5dev/vpc/keyvalues.cpp
+++ b/r5dev/vpc/keyvalues.cpp
@@ -157,6 +157,7 @@ void KeyValues::Clear(void)
 //-----------------------------------------------------------------------------
 void KeyValues::DeleteThis(void)
 {
+	this->~KeyValues();
 	MemAllocSingleton()->Free(this);
 }