R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid extraneous string copy

Browse Source 
Take raw pointer directly, this is currently the only way these functions get called with.
This commit is contained in:
Kawe Mazidjatari 2023-06-19 22:36:46 +02:00
parent 91ec38645c
commit bc995230fa
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
r5dev/public/tier0/sigcache.h
View File

@ -29,8 +29,8 @@ public:
void AddEntry(const char* szPattern, const uint64_t nRVA);
bool FindEntry(const char* szPattern, uint64_t& nRVA);
bool LoadCache(const string& svCacheFile);
bool WriteCache(const string& svCacheFile) const;
bool LoadCache(const char* szCacheFile);
bool WriteCache(const char* szCacheFile) const;
private:
bool CompressBlob(const size_t nSrcLen, size_t& nDstLen, uint32_t& nAdler32, const uint8_t* pSrcBuf, uint8_t* pDstBuf) const;

10
r5dev/tier0/sigcache.cpp
View File

@ -83,7 +83,7 @@ bool CSigCache::FindEntry(const char* szPattern, uint64_t& nRVA)
// Purpose: loads the cache map from the disk
// Output : true on success, false otherwise
//-----------------------------------------------------------------------------
bool CSigCache::LoadCache(const string& svCacheFile)
bool CSigCache::LoadCache(const char* szCacheFile)
{
Assert(!m_bInitialized); // Recursive load.
@ -93,7 +93,7 @@ bool CSigCache::LoadCache(const string& svCacheFile)
}
CIOStream reader;
if (!reader.Open(svCacheFile, CIOStream::READ | CIOStream::BINARY))
if (!reader.Open(szCacheFile, CIOStream::READ | CIOStream::BINARY))
{
return false;
}
@ -159,7 +159,7 @@ bool CSigCache::LoadCache(const string& svCacheFile)
// Purpose: writes the cache map to the disk
// Output : true on success, false otherwise
//-----------------------------------------------------------------------------
bool CSigCache::WriteCache(const string& svCacheFile) const
bool CSigCache::WriteCache(const char* szCacheFile) const
{
if (m_bDisabled || m_bInitialized)
{
@ -168,10 +168,10 @@ bool CSigCache::WriteCache(const string& svCacheFile) const
}
CIOStream writer;
if (!writer.Open(svCacheFile, CIOStream::WRITE | CIOStream::BINARY))
if (!writer.Open(szCacheFile, CIOStream::WRITE | CIOStream::BINARY))
{
Error(eDLL_T::COMMON, NO_ERROR, "%s - Unable to write to '%s' (read-only?)\n",
__FUNCTION__, svCacheFile.c_str());
__FUNCTION__, szCacheFile);
return false;
}