R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Pylon: fix use after free

Browse Source 
The member must contain a copy of the string, pointing it to the buffer used by the language cvar results in undefined behavior. Several cases were the string pointed to random data were reported.
This commit is contained in:
Kawe Mazidjatari 2023-10-08 16:37:10 +02:00
parent ab1d28c778
commit c3e11b4283
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/networksystem/pylon.cpp
View File

@ -390,8 +390,7 @@ bool CPylon::QueryServer(const char* endpoint, const char* request,
string finalUrl;
CURLFormatUrl(finalUrl, hostName, endpoint);
finalUrl += Format("?language=%s", this->m_Language);
finalUrl += Format("?language=%s", this->m_Language.c_str());
CURLParams params;

2
src/networksystem/pylon.h
View File

@ -34,6 +34,6 @@ public:
private:
string m_Token;
string m_ErrorMsg;
const char* m_Language;
string m_Language;
};
extern CPylon* g_pMasterServer;