From c49209bd1e88423b539d47ffd67456380d7531be Mon Sep 17 00:00:00 2001
From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com>
Date: Thu, 26 Jan 2023 03:00:53 +0100
Subject: [PATCH] Log truncated files if they are listed in the VPK build
 manifest

---
 r5dev/vpklib/packedstore.cpp | 36 ++++++++++++++++++++----------------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/r5dev/vpklib/packedstore.cpp b/r5dev/vpklib/packedstore.cpp
index c814f97d..7aec09b7 100644
--- a/r5dev/vpklib/packedstore.cpp
+++ b/r5dev/vpklib/packedstore.cpp
@@ -154,27 +154,31 @@ vector<VPKKeyValues_t> CPackedStore::GetEntryValues(const string& svWorkspace, K
 		if (it != vIgnoredList.end())
 		{
 			dir.disable_recursion_pending(); // Skip all ignored folders and extensions.
+			continue;
 		}
-		else if (dir->file_size() > 0) // Empty files are not supported.
+		const string svFullPath = ConvertToWinPath(dir->path().u8string());
+		if (!GetExtension(svFullPath).empty())
 		{
-			const string svFullPath = ConvertToWinPath(dir->path().u8string());
-			if (!GetExtension(svFullPath).empty())
-			{
-				// Remove workspace path by offsetting it by its size.
-				const char* pszEntry = (svFullPath.c_str() + svWorkspace.length());
-				KeyValues* pEntryKV = pManifestKV->FindKey(pszEntry);
+			// Remove workspace path by offsetting it by its size.
+			const char* pszEntry = (svFullPath.c_str() + svWorkspace.length());
+			KeyValues* pEntryKV = pManifestKV->FindKey(pszEntry);
 
-				if (pEntryKV)
+			if (pEntryKV)
+			{
+				if (!dir->file_size()) // Empty files are not supported.
 				{
-					vEntryValues.push_back(VPKKeyValues_t(
-						ConvertToUnixPath(svFullPath),
-						pEntryKV->GetInt("preloadSize", NULL),
-						pEntryKV->GetInt("loadFlags", static_cast<uint32_t>(EPackedLoadFlags::LOAD_VISIBLE) | static_cast<uint32_t>(EPackedLoadFlags::LOAD_CACHE)),
-						pEntryKV->GetInt("textureFlags", static_cast<uint16_t>(EPackedTextureFlags::TEXTURE_DEFAULT)),
-						pEntryKV->GetBool("useCompression", true),
-						pEntryKV->GetBool("useDataSharing", true))
-					);
+					Warning(eDLL_T::FS, "File '%s' listed in build manifest appears truncated\n", dir->path().relative_path().c_str());
+					continue;
 				}
+
+				vEntryValues.push_back(VPKKeyValues_t(
+					ConvertToUnixPath(svFullPath),
+					pEntryKV->GetInt("preloadSize", NULL),
+					pEntryKV->GetInt("loadFlags", static_cast<uint32_t>(EPackedLoadFlags::LOAD_VISIBLE) | static_cast<uint32_t>(EPackedLoadFlags::LOAD_CACHE)),
+					pEntryKV->GetInt("textureFlags", static_cast<uint16_t>(EPackedTextureFlags::TEXTURE_DEFAULT)),
+					pEntryKV->GetBool("useCompression", true),
+					pEntryKV->GetBool("useDataSharing", true))
+				);
 			}
 		}
 		dir++;