R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Recast: add bounds check for sweepscan indices

Browse Source 
Only happens on extremely large and complex geometry.
This commit is contained in:
Kawe Mazidjatari 2024-10-13 14:39:52 +02:00
parent 248a652a15
commit c9c687fc73
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/thirdparty/recast/Recast/Source/RecastRegion.cpp vendored
View File

@ -1425,6 +1425,15 @@ bool rcBuildRegionsMonotone(rcContext* ctx, rcCompactHeightfield& chf,
if (!previd)
{
previd = rid++;
// todo(amos): figure out why this happens on very complex and large
// input geometry.
if (previd >= nsweeps)
{
ctx->log(RC_LOG_ERROR, "rcBuildLayerRegions: Sweep index out of bounds: previd (%d), nsweeps (%d).", previd, nsweeps);
return false;
}
sweeps[previd].rid = previd;
sweeps[previd].ns = 0;
sweeps[previd].nei = 0;
@ -1734,6 +1743,15 @@ bool rcBuildLayerRegions(rcContext* ctx, rcCompactHeightfield& chf,
if (!previd)
{
previd = rid++;
// todo(amos): figure out why this happens on very complex and large
// input geometry.
if (previd >= nsweeps)
{
ctx->log(RC_LOG_ERROR, "rcBuildLayerRegions: Sweep index out of bounds: previd (%d), nsweeps (%d).", previd, nsweeps);
return false;
}
sweeps[previd].rid = previd;
sweeps[previd].ns = 0;
sweeps[previd].nei = 0;