R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

CMake: turn off fast math

Browse Source 
The engine is not compiled with fast math. Added a detailed comment explaining how this was figured out and why it should be kept disabled.
This commit is contained in:
Kawe Mazidjatari 2024-10-28 17:15:00 +01:00
parent 787fc85f29
commit ca2e8bc32d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cmake/Macros.cmake
View File

@ -75,7 +75,14 @@ macro( add_module MODULE_TYPE MODULE_NAME REUSE_PCH FOLDER_NAME WARNINGS_AS_ERRO
$<$<AND:$<CXX_COMPILER_ID:MSVC>,$<CONFIG:Release>>:/GS->
$<$<AND:$<CXX_COMPILER_ID:MSVC>,$<CONFIG:Release>>:/Gy>
$<$<AND:$<CXX_COMPILER_ID:MSVC>,$<CONFIG:Release>>:/GT>
$<$<AND:$<CXX_COMPILER_ID:MSVC>,$<CONFIG:Release>>:/fp:fast>
# The GDC talk regarding SIMD BVH4 collision detection held by the
# developers of the engine, mentions at https://gdcvault.com/play/1025126/Extreme-SIMD-Optimized-Collision-Detection
# on the 23:45 minute mark (or https://youtu.be/6BIfqfC1i7U?t=1429 for a direct link to the time stamp on YouTube)
# that fast math isn't enabled as the compiler optimizes NaN
# comparisons away. In order to ensure full ABI compatibility
# when detouring routines using any kind of math, this option
# should be kept disabled.
#$<$<AND:$<CXX_COMPILER_ID:MSVC>,$<CONFIG:Release>>:/fp:fast>
)
endif()
endmacro()