From ca3e5ac9d18a8e388764c761ee6df939aa014cb0 Mon Sep 17 00:00:00 2001 From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com> Date: Sun, 15 Jan 2023 18:12:39 +0100 Subject: [PATCH] ImGuiConfig: fix incorrect allocation size causing OOB memory write Fix was found after the issue in the previous commit was found. --- r5dev/thirdparty/imgui/src/imgui_utility.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/r5dev/thirdparty/imgui/src/imgui_utility.cpp b/r5dev/thirdparty/imgui/src/imgui_utility.cpp index b69e3e9d..8d2619aa 100644 --- a/r5dev/thirdparty/imgui/src/imgui_utility.cpp +++ b/r5dev/thirdparty/imgui/src/imgui_utility.cpp @@ -22,7 +22,7 @@ void ImGuiConfig::Load() } uint32_t nLen = FileSystem()->Size(hFile); - uint8_t* pBuf = MemAllocSingleton()->Alloc(nLen); + uint8_t* pBuf = MemAllocSingleton()->Alloc(nLen + 1); int nRead = FileSystem()->Read(pBuf, nLen, hFile); FileSystem()->Close(hFile);