From cbed704bab834055cf81e5f711895bc5895ac2eb Mon Sep 17 00:00:00 2001
From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com>
Date: Sun, 12 Feb 2023 19:05:34 +0100
Subject: [PATCH] Performance improvements for str tools

Improve performance for 'StringToMaskedBytes' and 'PatternToMaskedBytes' by appending characters as immediate (char) values instead of pointers.
---
 r5dev/public/utility/utility.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/r5dev/public/utility/utility.cpp b/r5dev/public/utility/utility.cpp
index 1d97b609..21b69776 100644
--- a/r5dev/public/utility/utility.cpp
+++ b/r5dev/public/utility/utility.cpp
@@ -844,7 +844,7 @@ vector<int> StringToBytes(const string& svInput, bool bNullTerminator)
 
     if (bNullTerminator)
     {
-        vBytes.push_back(0x0);
+        vBytes.push_back('\0');
     }
     return vBytes;
 };
@@ -862,13 +862,13 @@ pair<vector<uint8_t>, string> StringToMaskedBytes(const string& svInput, bool bN
     {
         // Dereference character and push back the byte.
         vBytes.push_back(*pszCurrentByte);
-        svMask.append("x");
+        svMask += 'x';
     }
 
     if (bNullTerminator)
     {
         vBytes.push_back(0x0);
-        svMask.append("x");
+        svMask += 'x';
     }
     return make_pair(vBytes, svMask);
 };
@@ -931,12 +931,12 @@ pair<vector<uint8_t>, string> PatternToMaskedBytes(const string& svInput)
                 ++pszCurrentByte; // Skip double wildcard.
             }
             vBytes.push_back(0); // Push the byte back as invalid.
-            svMask.append("?");
+            svMask += '?';
         }
         else
         {
             vBytes.push_back(strtoul(pszCurrentByte, &pszCurrentByte, 16));
-            svMask.append("x");
+            svMask += 'x';
         }
     }
     return make_pair(vBytes, svMask);