From cce4429606461ab7bd10a6050aee78790e639e84 Mon Sep 17 00:00:00 2001
From: O-Robotic <O-Robotic@users.noreply.github.com>
Date: Sun, 10 Nov 2024 17:00:23 +0000
Subject: [PATCH] Pylon: Fix incorrect return value in GetBannedList
 GetBannedList was returning true even when no players were pushed to the
 banlist causing excessive thread creation in the bulk check system.

---
 src/networksystem/pylon.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/networksystem/pylon.cpp b/src/networksystem/pylon.cpp
index b4508c57..acac5d24 100644
--- a/src/networksystem/pylon.cpp
+++ b/src/networksystem/pylon.cpp
@@ -287,9 +287,13 @@ bool CPylon::GetBannedList(const CBanSystem::BannedList_t& inBannedVec, CBanSyst
             CBanSystem::Banned_t banned(reason ? reason : "#DISCONNECT_BANNED", nuc);
             (*outBannedVec)->AddToTail(banned);
         }
-    }
 
-    return true;
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 //-----------------------------------------------------------------------------