From daa931ef640925a95e8b13039dbd734632d89e6f Mon Sep 17 00:00:00 2001
From: Kawe Mazidjatari <48657826+Mauler125@users.noreply.github.com>
Date: Sat, 18 Jun 2022 17:52:32 +0200
Subject: [PATCH] Use appropriate type for CFactory::GetVersionIndex

svInterfaceName.length() is size_t, and substr takes size_t.
---
 r5dev/vpc/interfaces.cpp | 10 +++++-----
 r5dev/vpc/interfaces.h   |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/r5dev/vpc/interfaces.cpp b/r5dev/vpc/interfaces.cpp
index 709cd30f..8a4c273f 100644
--- a/r5dev/vpc/interfaces.cpp
+++ b/r5dev/vpc/interfaces.cpp
@@ -14,7 +14,7 @@
 //---------------------------------------------------------------------------------
 void CFactory::AddFactory(const string& svFactoryName, void* pFactory)
 {
-	int nVersionIndex = GetVersionIndex(svFactoryName);
+	size_t nVersionIndex = GetVersionIndex(svFactoryName);
 	FactoryInfo factoryInfo = FactoryInfo(svFactoryName, svFactoryName.substr(0, nVersionIndex),
 		svFactoryName.substr(nVersionIndex), reinterpret_cast<uintptr_t>(pFactory));
 
@@ -35,10 +35,10 @@ void CFactory::AddFactory(FactoryInfo factoryInfo)
 // Input  : svInterfaceName - 
 // Output : index of version in input interface string
 //---------------------------------------------------------------------------------
-int CFactory::GetVersionIndex(const string& svInterfaceName) const
+size_t CFactory::GetVersionIndex(const string& svInterfaceName) const
 {
-	int nVersionIndex = 0;
-	for (int i = 0; i < svInterfaceName.length(); i++) // Loop through each charater to find the start of interface version.
+	size_t nVersionIndex = 0;
+	for (size_t i = 0; i < svInterfaceName.length(); i++) // Loop through each charater to find the start of interface version.
 	{
 		if (std::isdigit(svInterfaceName[i]))
 		{
@@ -58,7 +58,7 @@ void CFactory::GetFactoriesFromRegister(void)
 		it; it = it->m_pNextInterfacePtr) // Loop till we go out of scope.
 	{
 		string svInterfaceName = it->m_pInterfaceName; // Get copy of the name.
-		int nVersionIndex = GetVersionIndex(svInterfaceName);
+		size_t nVersionIndex = GetVersionIndex(svInterfaceName);
 
 		// Push back the interface.
 		AddFactory(FactoryInfo(svInterfaceName, svInterfaceName.substr(0, nVersionIndex), 
diff --git a/r5dev/vpc/interfaces.h b/r5dev/vpc/interfaces.h
index 10655a54..33aafbbf 100644
--- a/r5dev/vpc/interfaces.h
+++ b/r5dev/vpc/interfaces.h
@@ -79,7 +79,7 @@ class CFactory
 public:
 	void AddFactory(const string& svFactoryName, void* pFactory);
 	void AddFactory(FactoryInfo factoryInfo);
-	int GetVersionIndex(const string& svInterfaceName) const;
+	size_t GetVersionIndex(const string& svInterfaceName) const;
 	void GetFactoriesFromRegister(void);
 	CMemory GetFactoryPtr(const string& factoryName, bool versionLess = true) const;