R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Engine: fix heap buffer overflow

Browse Source 
Should always leave 1 byte for the null terminator in the persona name buffer.
This commit is contained in:
Kawe Mazidjatari 2024-11-14 15:26:40 +01:00
parent da6ffe9005
commit e8fe12b4fd
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/engine/client/clientstate.cpp
View File

@ -43,12 +43,11 @@ static void SetName_f(const CCommand& args)
const size_t nLen = strlen(pszName);
if (nLen > MAX_PERSONA_NAME_LEN)
if (nLen >= MAX_PERSONA_NAME_LEN)
return;
// Update nucleus name.
memset(g_PersonaName, '\0', MAX_PERSONA_NAME_LEN);
strncpy(g_PersonaName, pszName, nLen);
strncpy(g_PersonaName, pszName, nLen+1);
}
static void Reconnect_f(const CCommand& args)
{