From 3247bd465d12c502e262ead8f97733210767cd0e Mon Sep 17 00:00:00 2001 From: Bill Hollings Date: Wed, 10 May 2023 16:46:41 -0400 Subject: [PATCH] GitHub CI streamline uploaded artifact sizes. - Reinstate per-platform upload artifacts. - Don't upload shader converter binaries. --- .github/workflows/CI.yml | 11 +++++++---- Docs/Whats_New.md | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index ae188be6..5102796e 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -16,7 +16,7 @@ jobs: strategy: matrix: xcode: [ "14.3" ] - platform: [ "all" ] + platform: [ "all", "macos", "ios" ] os: [ "macos-13" ] upload_artifacts: [ true ] # additional specific configurations @@ -94,14 +94,17 @@ jobs: - name: Tar Artifacts if: success() && matrix.upload_artifacts == true # See: https://github.com/actions/upload-artifact#maintaining-file-permissions-and-case-sensitive-files - run: tar -C Package -s/Release/MoltenVK/ -cvf "MoltenVK.tar" Release/ + # To reduce artifact size, don't include any stand-alone shader converter binaries. + run: | + rm -rf Package/Release/MoltenVKShaderConverter + tar -C Package -s/Release/MoltenVK/ -cvf "MoltenVK-${{ matrix.platform }}.tar" Release/ - name: Upload Artifacts if: success() && matrix.upload_artifacts == true uses: actions/upload-artifact@v3 with: - name: "MoltenVK" - path: "MoltenVK.tar" + name: "MoltenVK-${{ matrix.platform }}" + path: "MoltenVK-${{ matrix.platform }}.tar" release: name: 'Release' diff --git a/Docs/Whats_New.md b/Docs/Whats_New.md index 76f3b586..947cd308 100644 --- a/Docs/Whats_New.md +++ b/Docs/Whats_New.md @@ -31,7 +31,7 @@ Released TBD disable recent fixes to handling LOD for arrayed depth images in shaders, on Apple Silicon, when those fixes cause regression in rendering behavior. - For correctness, set `VkPhysicalDeviceLimits::lineWidthGranularity` to `1`. -- Modify GitHub CI to build and create a single universal binary artifact. +- Improve GitHub CI production of binary artifacts on submission and release.