Ryujinx/moltenvk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MVKCmdFillBuffer: Round size down, not up.

Browse Source 
According to the Vulkan spec:

> If `VK_WHOLE_SIZE` is used and the remaining size of the buffer is not
> a multiple of 4, then the nearest **smaller** multiple is used.
> [emphasis added]

Therefore, we should round down when calculating the number of words to
write.
This commit is contained in:
Chip Davis 2020-09-26 00:08:58 -05:00
parent f319e9bd68
commit 5794503876
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MoltenVK/MoltenVK/Commands/MVKCmdTransfer.mm
View File

@ -1446,9 +1446,9 @@ VkResult MVKCmdFillBuffer::setContent(MVKCommandBuffer* cmdBuff,
_dstOffset = dstOffset;
_dataValue = data;
// Round up in case of VK_WHOLE_SIZE on a buffer size which is not aligned to 4 bytes.
// Round down in case of VK_WHOLE_SIZE on a buffer size which is not aligned to 4 bytes.
VkDeviceSize byteCnt = (size == VK_WHOLE_SIZE) ? (_dstBuffer->getByteCount() - _dstOffset) : size;
VkDeviceSize wdCnt = (byteCnt + 3) >> 2;
VkDeviceSize wdCnt = byteCnt >> 2;
if (mvkFits<uint32_t>(wdCnt)) {
_wordCount = (uint32_t)wdCnt;
} else {