Ryujinx/moltenvk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1060 from cdavis5e/layered-clears

Browse Source 
MVKCmdClearImage: Use layered rendering when possible.
This commit is contained in:
Bill Hollings 2020-09-22 17:47:47 -04:00 committed by GitHub
commit 6cfe8cdd36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
MoltenVK/MoltenVK/Commands/MVKCmdTransfer.mm
View File

@ -1345,6 +1345,26 @@ void MVKCmdClearImage<N>::encode(MVKCommandEncoder* cmdEncoder) {
layerEnd = layerStart + layerCnt; layerEnd = layerStart + layerCnt;
} }
// If we can do layered rendering, I can clear all the layers at once.
if (cmdEncoder->getDevice()->_pMetalFeatures->layeredRendering &&
(_image->getSampleCount() == VK_SAMPLE_COUNT_1_BIT || cmdEncoder->getDevice()->_pMetalFeatures->multisampleLayeredRendering)) {
if (is3D) {
mtlRPCADesc.depthPlane = layerStart;
mtlRPDADesc.depthPlane = layerStart;
mtlRPSADesc.depthPlane = layerStart;
} else {
mtlRPCADesc.slice = layerStart;
mtlRPDADesc.slice = layerStart;
mtlRPSADesc.slice = layerStart;
}
mtlRPDesc.renderTargetArrayLength = (layerCnt == VK_REMAINING_ARRAY_LAYERS
? (_image->getLayerCount() - layerStart)
: layerCnt);
id<MTLRenderCommandEncoder> mtlRendEnc = [cmdEncoder->_mtlCmdBuffer renderCommandEncoderWithDescriptor: mtlRPDesc];
setLabelIfNotNil(mtlRendEnc, mtlRendEncName);
[mtlRendEnc endEncoding];
} else {
for (uint32_t layer = layerStart; layer < layerEnd; layer++) { for (uint32_t layer = layerStart; layer < layerEnd; layer++) {
if (is3D) { if (is3D) {
mtlRPCADesc.depthPlane = layer; mtlRPCADesc.depthPlane = layer;
@ -1362,6 +1382,7 @@ void MVKCmdClearImage<N>::encode(MVKCommandEncoder* cmdEncoder) {
} }
} }
} }
}
} }
template class MVKCmdClearImage<1>; template class MVKCmdClearImage<1>;