Ryujinx/moltenvk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove limit on VkPhysicalDeviceLimits::maxSamplerAllocationCount

Browse Source 
when not using Metal argument buffers.
This commit is contained in:
Bill Hollings 2022-03-10 18:12:54 -05:00
parent d3b5d113f7
commit a91a3d000a
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Docs/Whats_New.md
View File

@ -23,6 +23,7 @@ Released TBD
- Fix alignment between outputs and inputs between shader stages when using nested structures. - Fix alignment between outputs and inputs between shader stages when using nested structures.
- Fix issue where the depth component of a stencil-only renderpass attachment was incorrectly attempting to be stored. - Fix issue where the depth component of a stencil-only renderpass attachment was incorrectly attempting to be stored.
- Fix deletion of GPU counter `MTLFence` while it is being used by `MTLCommandBuffer`. - Fix deletion of GPU counter `MTLFence` while it is being used by `MTLCommandBuffer`.
- Remove limit on `VkPhysicalDeviceLimits::maxSamplerAllocationCount` when not using Metal argument buffers.
- `MoltenVKShaderConverter` tool defaults to the highest MSL version supported on runtime OS. - `MoltenVKShaderConverter` tool defaults to the highest MSL version supported on runtime OS.
- Update *glslang* version, to use `python3` in *glslang* scripts, to replace missing `python` on *macOS 12.3*. - Update *glslang* version, to use `python3` in *glslang* scripts, to replace missing `python` on *macOS 12.3*.
- Update to latest SPIRV-Cross: - Update to latest SPIRV-Cross:

11
MoltenVK/MoltenVK/GPUObjects/MVKDevice.mm
View File

@ -2698,9 +2698,16 @@ uint64_t MVKPhysicalDevice::getCurrentAllocatedSize() {
#endif #endif
} }
// When using argument buffers, Metal imposes a hard limit on the number of MTLSamplerState
// objects that can be created within the app. When not using argument buffers, no such
// limit is imposed. This has been verified with testing up to 1M MTLSamplerStates.
uint32_t MVKPhysicalDevice::getMaxSamplerCount() { uint32_t MVKPhysicalDevice::getMaxSamplerCount() {
return ([_mtlDevice respondsToSelector: @selector(maxArgumentBufferSamplerCount)] if (isUsingMetalArgumentBuffers()) {
? (uint32_t)_mtlDevice.maxArgumentBufferSamplerCount : 1024); return ([_mtlDevice respondsToSelector: @selector(maxArgumentBufferSamplerCount)]
? (uint32_t)_mtlDevice.maxArgumentBufferSamplerCount : 1024);
} else {
return kMVKUndefinedLargeUInt32;
}
} }
void MVKPhysicalDevice::initExternalMemoryProperties() { void MVKPhysicalDevice::initExternalMemoryProperties() {