Ryujinx/moltenvk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Closes issue #17. Modify MVKImageView::populateMTLRenderPassAttachmentDescriptor and MVKImageView::populateMTLRenderPassAttachmentDescriptorResolve to use the MTLTextureView rather than MTLTexture. This makes sure that the texture view with the correct format is used for the renderpass. For example, in the case of a mutable image with sRGB and UNORM format, the correct format will be used for the renderpass attachment.

Browse Source
This commit is contained in:
Dan Ginsburg 2018-01-12 09:20:47 -05:00
parent 29e853ca15
commit e4d8f5afa6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MoltenVK/MoltenVK/GPUObjects/MVKImage.mm
View File

@ -518,14 +518,14 @@ MVKImage::~MVKImage() {
void MVKImageView::populateMTLRenderPassAttachmentDescriptor(MTLRenderPassAttachmentDescriptor* mtlAttDesc) {
mtlAttDesc.texture = _image->getMTLTexture(); // Use underlying image texture, since RP attachment handles subresource
mtlAttDesc.texture = getMTLTexture(); // Use image view, necessary if image view format differs from image format
mtlAttDesc.level = _subresourceRange.baseMipLevel;
mtlAttDesc.slice = _subresourceRange.baseArrayLayer;
mtlAttDesc.depthPlane = 0;
}
void MVKImageView::populateMTLRenderPassAttachmentDescriptorResolve(MTLRenderPassAttachmentDescriptor* mtlAttDesc) {
mtlAttDesc.resolveTexture = _image->getMTLTexture(); // Use underlying image texture, since RP attachment handles subresource
mtlAttDesc.resolveTexture = getMTLTexture(); // Use image view, necessary if image view format differs from image format
mtlAttDesc.resolveLevel = _subresourceRange.baseMipLevel;
mtlAttDesc.resolveSlice = _subresourceRange.baseArrayLayer;
mtlAttDesc.resolveDepthPlane = 0;