Ryujinx/moltenvk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MVKDevice: Constant buffer bindings on macOS cannot exceed 64k.

Browse Source 
This limitation appears to be have been present all along (cf. Metal
Feature Set Tables, under "Maximum function memory allocation for a
buffer in the constant address space"). I guess we never ran into it
before.

Prompted by #730.
This commit is contained in:
Chip Davis 2019-09-03 11:03:08 -05:00
parent 4695b63532
commit e7e8610a62
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
MoltenVK/MoltenVK/GPUObjects/MVKDevice.mm
View File

@ -1136,7 +1136,12 @@ void MVKPhysicalDevice::initProperties() {
} else {
_properties.limits.maxTexelBufferElements = _properties.limits.maxImageDimension2D * _properties.limits.maxImageDimension2D;
}
#if MVK_MACOS
_properties.limits.maxUniformBufferRange = (64 * KIBI);
#endif
#if MVK_IOS
_properties.limits.maxUniformBufferRange = (uint32_t)_metalFeatures.maxMTLBufferSize;
#endif
_properties.limits.maxStorageBufferRange = (uint32_t)_metalFeatures.maxMTLBufferSize;
_properties.limits.maxPushConstantsSize = (4 * KIBI);