R5Reloaded/r5sdk
1
0
Fork 0
mirror of https://github.com/Mauler125/r5sdk.git synced 2025-02-09 19:15:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

CL_CopyExistingEntity: remove Host_Error call

Browse Source 
Calling Host_Error at this stage will cause a dead lock. Removed the call after performing several test (i think the reason all error calls are removed as of Titanfall 2 and Apex Legends (compared to Titanfall 1) is for this reason). Returning false does the job and allows the client to recover as soon as a valid packet comes in.
This commit is contained in:
Kawe Mazidjatari 2022-09-21 20:13:51 +02:00
parent 7912b79fa2
commit 693516ceb3
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
r5dev/engine/client/cl_ents_parse.cpp
View File

@ -4,12 +4,8 @@
//
// $NoKeywords: $
//=============================================================================//
#include "core/stdafx.h"
#include "tier0/frametask.h"
#include "public/const.h"
#include "engine/host.h"
#include "engine/client/cl_ents_parse.h"
bool CL_CopyExistingEntity(__int64 a1, unsigned int* a2, char* a3)
@ -17,7 +13,13 @@ bool CL_CopyExistingEntity(__int64 a1, unsigned int* a2, char* a3)
int nNewEntity = *reinterpret_cast<int*>(a1 + 40);
if (nNewEntity >= MAX_EDICTS || nNewEntity < 0)
{
v_Host_Error("CL_CopyExistingEntity: m_nNewEntity >= MAX_EDICTS");
// Value isn't sanitized in release builds for
// every game powered by the Source Engine 1
// causing read/write outside of array bounds.
// This defect has let to the achievement of a
// full-chain RCE exploit. We hook and perform
// sanity checks for the value of m_nNewEntity
// here to prevent this behavior from happening.
return false;
}
return v_CL_CopyExistingEntity(a1, a2, a3);