791 Commits

Author SHA1 Message Date
Bill Hollings
327418a6b6 Broaden conditions for host read sync for image memory barriers on macOS.
Ignore pipeline dstStageMask and accept VK_ACCESS_MEMORY_READ_BIT in dstAccessMask.
2020-04-01 16:22:30 -04:00
Bill Hollings
453fbb4045 MVKImage fixes for texture view creation.
Fix potential deadlock when getMTLTexture(MTLPixelFormat) calls getMTLTexture().
Clear texture views when base texture is removed.
2020-03-31 13:25:20 -04:00
Bill Hollings
d5c62cc55a Reorganize code in MVKImage.h/mm to move MVKSwapchainImage closer to MVKImage. 2020-03-30 19:35:01 -04:00
Bill Hollings
b882161519 Do not create depth/stencil MTLTextures from MTLHeap.
See GitHub issues 792 & 832. Depth/stencil textures issued from MTLHeap can be flaky in
some situations, including depth-only rendering on Intel GPUs, and corruption when DS
texture with sampling usage is combined with non-DS texture on a single placement heap.
2020-03-30 15:39:34 -04:00
Bill Hollings
a0e3ab59f4 MVKPhysicalDevice add macros to simplify testing MTLFeatureSet and MTLGPUFamily.
Remove MVKPhysicalDevice::getSupportsGPUFamily();
2020-03-30 14:17:49 -04:00
Bill Hollings
8ec5f93802 MVKInstance instantiate MVKPhysicalDevices in-place instead of using new. 2020-03-30 13:13:54 -04:00
Bill Hollings
fee050372b Move derivation of MTLTextureUsage to MVKPixelFormats.
Add MVKPixelFormats::getMTLTextureUsageFromVkImageUsageFlags(), which takes
into account limitations of pixel formats.
MVKImage remove getMTLTextureUsage(), getSupportsAnyFormatFeature()
and getSupportsAllFormatFeatures().
MVKPixelFormats tracks MVKPhysicalDevice, not just MVKVulkanAPIObject.
MVKPixelFormats refactor constructors and internal retrieval of MTLDevice.
Add MTLPixelFormat to mvkMTLTextureUsageFromVkImageUsageFlags() params for compatibility.
Remove optionality of hasResolveAttachment param in
mvkMTLStoreActionFromVkAttachmentStoreOp() to support C calling.
2020-03-30 12:45:18 -04:00
Bill Hollings
5728f50f0f Add mvkOSVersionIsAtLeast() to simplify and standardizing testing OS version. 2020-03-28 20:11:21 -04:00
Bill Hollings
bd4e78d5a4 Update to latest SPIRV-Cross and Vulkan-Headers and fixes to pipeline cache loading.
Update Cereal archive structs to match latest MoltenVK and SPIRV-Cross structs.
Fix recent error that caused pipeline cache data to be ignored during loading.
Update to Vulkan-Headers version 1.2.135.
Update to latest SPIRV-Cross version.
Update Whats_New.md document.
2020-03-26 18:57:46 -04:00
Bill Hollings
3fa95d4c06 Refactor MVKImageView use without MVKDevice for testing formats.
Replace MVKImageView::getSwizzledMTLPixelFormat() with static validateSwizzledMTLPixelFormat()
to support querying format support without having to create fake MVKImageView instance from
MVKPhysicalDevice::getImageViewIsSupported().
Remove ability for MVKDeviceTrackingMixin and subclasses to work without a MVKDevice.
Remove mvkPlatformPixelFormats().
2020-03-26 14:40:08 -04:00
Bill Hollings
04ae0a61e0 Replace use of memcmp() with mvkAreEqual(). 2020-03-26 11:14:03 -04:00
Bill Hollings
4f1cdef6af Validate format capabilities for MSAA, renderpass attachments, and vkCmdResolveImage().
vkGetPhysicalDeviceImageFormatProperties() tests whether format supports MSAA.
vkCreateRenderPass() validate each attachment supports format capabilities required
by each subpass that uses it.
vkCmdResolveImage() validate that destination attachment supports being resolved to.
MVKPixelFormats add getVkFormatCapabilities(), getMTLPixelFormatCapabilities(),
and vkFormatIsSupportedOrSubstitutable().
Rework type handling in flag functions in MVKFoundation.h.
2020-03-26 00:05:01 -04:00
Bill Hollings
50eba6fee1 Support Xcode 11.4. 2020-03-25 20:24:07 -04:00
Bill Hollings
b09bb763bc Consolidate further static format functions into MVKPixelFormats. 2020-03-25 17:32:29 -04:00
Bill Hollings
622d75f0d2 Rename mvkEnableFlag() to mvkEnableFlags(). 2020-03-25 16:48:53 -04:00
Bill Hollings
b7c742af15 MVKPixelFormats unit tests only run on system default MTLDevice and only run once. 2020-03-23 23:09:34 -04:00
Bill Hollings
a93f2d2f67 Static format functions in mvk_datatypes.mm delegate to MTLPixelFormats.
MVKPixelFormats default constructor use default MTLDevice to initialize.
2020-03-23 22:36:20 -04:00
Bill Hollings
0c03f09df3 Accurately populate Vulkan VkFormatProperties from MTLPixelFormat capabilities,
taking into consideration variations across MTLDevice Features Sets.

Simplify contents and names in MVKMTLFmtCaps enum.
Add MVKVkFormatFeatureFlags enum to map capabilities from MVKMTLFmtCaps to VkFormat.
Derive three VkFormatFeatureFlags in VkFormatProperties from documented
MTLPixelFormat capabilities, customizing based on MTLDevice feature sets.
Include VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT and
VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_ATOMIC_BIT in writable features.
MVKPixelFormats modify VkFormatProperties unit test to log differences.
2020-03-23 21:28:36 -04:00
Bill Hollings
06dcf8dc70 Rename mvkDisableFlag() to mvkDisableFlags(). 2020-03-23 16:58:07 -04:00
Bill Hollings
5a5978f021 MVKPixelFormats determine Metal format support from format caps instead of OS version.
MVKPixelFormats build and modify Metal format maps before building Vulkan format maps.
MVKMTLFormatDesc remove sinceOSVersion and isSupported() checks format caps instead.
Remove datafilling of OS versions in MVKMTLFormatDesc.
2020-03-22 21:10:25 -04:00
Bill Hollings
329c1187d5 MVKPixelFormats add MTLVertexFormat capabilities based on MTLDevice feature set. 2020-03-22 18:29:34 -04:00
Bill Hollings
1b09f4a6b1 MVKPixelFormats add MTLPixelFormat capabilities based on MTLDevice feature set. 2020-03-21 21:46:45 -04:00
Bill Hollings
cdbf70d58b Define and populate default MTLPixelFormat capabilities.
MVKPixelFormats improve readability of datafilling of VkFormat, MTLPixelFormat,
and MTLVertexFormat capabilities using dynamic symbol macros to allow abbreviations.
Add MVKMTLFmtCaps enum to track MTLPixelFormat capabilities, and populate table of
default MTLPixelFormat and MTLVertexFormat capabilities.
Add mvkSelectPlatformValue() template function to support
selecting values based on the OS platform.
2020-03-20 20:56:24 -04:00
Bill Hollings
f58cb03ef9 MVKPixelFormats trim format descriptor population functions. 2020-03-17 13:01:03 -04:00
Bill Hollings
a2e995e5b2 Refactor and rename MVKPixelFormat getDesc...() functions. 2020-03-17 11:14:52 -04:00
Bill Hollings
bb69a5bfc6 Refactor MVKPixelFormat internals.
Split MVKFormatDesc struct into separate MVKVkFormatDesc & MVKMTLFormatDesc structs.
Separate content into Vulkan and Metal format tables.
2020-03-17 10:39:49 -04:00
Bill Hollings
1f74a6f20d Replace use of misc global pixel functions with MVKPixelFormats versions.
Remove mvkMTLVertexFormatFromVkFormatInObj()
and mvkEnumerateSupportedFormats() functions.
2020-03-16 11:45:16 -04:00
Bill Hollings
cdd9fcb18c Replace use of global clear value functions with MVKPixelFormats versions.
MVKPixelFormats add getMTLClearDepthFromVkClearValue()
and getMTLClearDepthFromVkClearValue().
2020-03-15 21:59:42 -04:00
Bill Hollings
fff2c43d47 Replace use of global format properties and
names functions with MVKPixelFormats versions.

Remove MVKPhysicalDevice::getFormatIsSupported().
2020-03-15 21:36:24 -04:00
Bill Hollings
0979151881 Replace use of global texel, block, row, and image
sizing functions with MVKPixelFormats versions.
2020-03-15 21:14:35 -04:00
Bill Hollings
c2ebbc732f Replace use of mvkMTLPixelFormatFromVkFormat() and mvkVkFormatFromMTLPixelFormat()
with MVKPixelFormats versions.

Remove mvkMTLPixelFormatFromVkFormatInObj().
2020-03-15 20:48:39 -04:00
Bill Hollings
e596e4c105 Replace use of mvkFormatTypeFromMTLPixelFormat() with
MVKPixelFormats::getFormatTypeFromMTLPixelFormat.
2020-03-15 20:15:24 -04:00
Bill Hollings
fb6f38e423 Replace use of mvkFormatTypeFromVkFormat() with MVKPixelFormats::getFormatTypeFromVkFormat. 2020-03-15 20:10:31 -04:00
Bill Hollings
fd4ad6ec54 Replace use of bool global format calls with calls to MVKPixelFormats. 2020-03-15 19:54:57 -04:00
Bill Hollings
0a8086cbc7 Support MVKPixelFormats in MVKDevice, MVKDeviceTrackingMixin, and MVKCommand.
Replace getMTLPixelFormatFromVkFormat() in MVKDevice, MVKDeviceTrackingMixin
and MVKCommand with access to getPixelFormats().
Add mvkPlatformPixelFormats() to support default platform pixel format info.
Rename MVKFormatDesc to MVKPlatformFormatDesc in mvk_datatypes.mm to avoid
naming conflict.
2020-03-15 19:12:39 -04:00
Bill Hollings
7658bccfba Fix memory leak when pre-filling MTLCommandBuffers.
Wrap MVKCommandBuffer::prefill() in autoreleasepool.
For non-reusable MVKCommandBuffers, release command instances
once prefilling is done to reduce memory pressure.
2020-03-14 16:56:12 -04:00
Bill Hollings
30658f05f5 Add ability to disable command memory pooling using MVK_CONFIG_USE_COMMAND_POOLING
environment variable.

Add ability to track MVKObjectPool allocation and pool residency counts.
2020-03-11 17:50:49 -04:00
Bill Hollings
bf4d121897 Manage MTLPixelFormatDepth24Unorm_Stencil8 support via MVKPixelFormats.
MVKPhysicalDevice hold instance of MVKPixelFormats.
Remove known unsupported from mvkMTLPixelFormatFromVkFormatInObj();
2020-03-10 11:50:20 -04:00
Bill Hollings
e9bbea96d1 Rename MVKFormats to MVKPixelFormats. 2020-03-10 08:38:43 -04:00
Bill Hollings
a9e5cb2914 Add initial MVKFormats class to manage Vulkan and Metal formats. 2020-03-08 14:50:37 -04:00
Bill Hollings
573fd67d93 Fixes to use of mvkClear() & mvkCopy().
Change mvkClear() & mvkCopy() to accept array size.
Fix clearing of array content using mvkClear().
Update number of VkDynamicStates that can be tracked.
Change copying of sizeable structs in vk_mvk_moltenvk.mm.
Add mvkAreEqual() to compare values, structs and arrays.
2020-03-07 17:11:55 -05:00
Bill Hollings
9e0ed9fbf4 Increase value of VkPhysicalDeviceLimits::minStorageBufferOffsetAlignment
to 16 to avoid Metal validation assertions.
2020-03-03 18:07:26 -05:00
Bill Hollings
8ac99ec0c5 Include thread ID and name when logging Vulkan calls. 2020-02-18 16:26:55 -05:00
Bill Hollings
860e1ef2fb MVKOcclusionQueryCommandEncoderState validate occlusion query during encoding step. 2020-02-16 17:10:30 -05:00
Bill Hollings
73984ba20c Guard against Metal validation assertion from reuse of
query number within a single MTLRenderEncoder.

Track MTLRenderEncoder used for each query and validate query is not reused within the
scope of a single MTLRenderEncoder, logging error and ending current query if encountered.
Remove _t from pre-typedef struct declarations.
Move declaration of MVKSwapchainImageAvailability from MVKImage.h to MVKSwapchain.h.
Update What's New document.
2020-02-15 21:49:13 -05:00
Bill Hollings
d7574d879d Fix issue where immutable samplers are removed during descriptor update.
Suppress spurious debug message.
Minor syntax fix.
Update MoltenVK version to 1.0.41.
2020-02-04 12:56:13 -05:00
Bill Hollings
593f773f48 Fix issue where preallocated descriptor count was not reset during vkResetDescriptorPool().
Document MVK_CONFIG_PREALLOCATE_DESCRIPTORS runtime environment variable.
Update MoltenVK_Runtime_UserGuide.md to better explain runtime environment variables.
Update Whats_New.md document.
2020-01-21 14:05:58 -05:00
Bill Hollings
8463eb5d8d
Merge pull request #818 from billhollings/master
Support preallocated descriptor pooling via VkDescriptorPoolSize.
2020-01-21 10:15:07 -05:00
Bill Hollings
6abf4a6e2f Support preallocated descriptor pooling via VkDescriptorPoolSize.
Add MVK_CONFIG_PREALLOCATE_DESCRIPTORS env var to enable descriptor preallocation
in pool. Add MVKDescriptor subclasses for all used VkDescriptorType values.
Support allocating MVKDescriptor subclasses via direct instantiation,
or referencing preallocated instances held in a fixed collection.
MVKDescriptor subclasses support resetting and reuse from preallocated collection.
MVKDescriptorPool optionally holds collections of preallocated descriptors,
one collection per VkDescriptorType value.
Support VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT to mark preallocated
descriptors as available when freed.
2020-01-21 09:18:18 -05:00
Bill Hollings
e53e582639 Move MVKDescriptor instantiation to MVKDescriptorPool and support allocation failures. 2020-01-15 16:29:14 -05:00