505 Commits

Author SHA1 Message Date
Bill Hollings
eca03b8de1 MoltenVKShaderConverter tool add MSL version and platform command-line options.
Add SPIRVToMSLConverterOptions::platform to track platform. Default to build platform.
Update default SPIRVToMSLConverterOptions MSL version to 2.1.
MoltenVKShaderConverter test MSL compilation use same MSL version as conversion.
Default min perf tracking value to 0.0.
SPIRVToMSLConverter.h reference spirv.hpp via SPIRV-Cross framework.
Update What's New document.
2019-04-17 16:09:07 -04:00
Michael Barriault
4c4332b848 Fix zero local threadgroup size in indirect rendering. 2019-04-15 17:58:26 +01:00
Chip Davis
5df1b1b7db Don't use setVertexBytes() for passing vertex counts.
In a tessellated draw, the vertex shader will take a `device` pointer to
the vertex count. It must be a `device` pointer, because the `constant`
AS on Mac requires 256-byte alignment, which we cannot guarantee,
particularly with an indirect draw. But, the `setVertexBytes:...` method
cannot be used with the `device` AS. So, we need yet another temporary
buffer to hold this value in the `device` AS.

Fixes #566.
2019-04-13 12:49:20 -05:00
Bill Hollings
d57704b69f
Merge pull request #570 from billhollings/master
Update dependency libraries for SDK 1.1.106.
2019-04-11 18:41:18 -04:00
Michael Barriault
9e7fe1b642 Fix tessellation pipeline re-clearing attachments. 2019-04-11 22:37:19 +01:00
Bill Hollings
ebce19b0b7 Add MoltenVKShaderConverter tool option to log shader conversion performance.
Move MVKOSExtension.h/mm to from MoltenVK to Common
and move MTLDevice functions to MVKDevice.
2019-04-11 14:26:35 -04:00
Bill Hollings
b09f52c50a Merge branch 'master' of https://github.com/KhronosGroup/MoltenVK 2019-04-11 10:00:20 -04:00
Bill Hollings
f326f0caec Log shader performance statistics in any runtime if
MVKConfiguration::performanceLoggingFrameCount is non-zero.
2019-04-09 23:24:44 -04:00
Michael Barriault
90baed604e Fix crash vertex pre-pass in tessellation pipeline due to being created with line topology but rendered with points. 2019-04-09 20:03:18 +01:00
Michael Barriault
761d80f81f Fix vertex pre-pass in tessellation pipeline not encoding. 2019-04-09 20:00:44 +01:00
Michael Barriault
a995a3b926 Fix patch count in tessellation pipeline. 2019-04-09 19:59:46 +01:00
Michael Barriault
7e1eafcee5 Fix reading storage images in shaders. 2019-04-09 19:59:09 +01:00
Michael Barriault
159a0c3919 Fix Metal version check macro 2019-04-09 19:58:05 +01:00
Bill Hollings
3e5b735355 Add MVK_CONFIG_TRACE_VULKAN_CALLS env var and build setting to log Vulkan calls made by application. 2019-04-03 16:39:27 -04:00
Bill Hollings
cf13ab08a2 Set MTLRenderPassDescriptor renderTargetWidth & renderTargetHeight
only when layered rendering supported, to avoid GPU crashes on older devices.
2019-04-03 14:58:57 -04:00
Bill Hollings
75a088dbe0 API: Add MVKPhysicalDeviceMetalFeatures::depthSampleCompare.
Set MTLSamplerDescriptor.compareFunction only if depthSampleCompare enabled.
Update VK_MVK_MOLTENVK_SPEC_VERSION to 19.
2019-04-02 00:40:57 -04:00
Bill Hollings
6a77fc950a Clean up recent commits for iOS compatibility.
Test for _pMetalFeatures->layeredRendering before setting
MTLRenderPassDescriptor.renderTargetArrayLength.
Change NSString comparisons using isEqualTo: to isEqualToString:.
2019-04-01 23:05:42 -04:00
Bill Hollings
dfd5638a0f Clean up use of SPIRV_CROSS_NAMESPACE_OVERRIDE in Xcode projects.
Setting of SPIRV_CROSS_NAMESPACE_OVERRIDE in Xcode projects was stomping on DEBUG setting.
Update What's New document.
2019-04-01 22:41:20 -04:00
Bill Hollings
0ce9fccd17
Merge pull request #559 from cdavis5e/rtarray-a12-fix
Actually set the renderTargetArrayLength property on iOS 12.
2019-04-01 21:56:18 -04:00
Chip Davis
9736aace54 Detect surface loss in the swapchain on iOS as well. 2019-04-01 16:43:13 -05:00
Chip Davis
d24ddb1831 Add missing braces. 2019-04-01 16:28:27 -05:00
Chip Davis
77ddaff4d4 Actually set the renderTargetArrayLength property on iOS 12.
Fixes #558.
2019-04-01 13:42:35 -05:00
Chip Davis
b8f22700d5 Handle surface loss.
Sometimes, the `CAMetalLayer` backing a view can be replaced--for
example, when the window is moved to another screen, or the style bits
on the window are changed. In that case, we must allow the client the
opportunity to recreate the surface and swapchain.

Layer-backed views always set themselves as the layer's delegate; we use
this fact to Key-Value Observe the view's `layer` property.

Other alternatives considered:

* Registering for `NSViewGlobalFrameDidChange` notifications. Aside from
  only working on macOS, this doesn't actually catch every case where we
  want to report a lost surface. I'm not even sure it works at all for
  Metal.
* Holding a reference to the view, and checking when its layer property
  has changed.
* Holding a weak reference to the layer; that way, the reference will
  become `nil` when the layer is replaced. But this requires ARC.
2019-04-01 13:11:01 -05:00
danginsburg
7199c2570b Fix https://github.com/KhronosGroup/MoltenVK/issues/553 by making the Metal renderpass descriptor width/height clamped to the renderArea including the offset, not just the extent. 2019-03-29 14:32:27 -04:00
Hans-Kristian Arntzen
38edfdb3de Override namespace for SPIRV-Cross.
Some projects also link against SPIRV-Cross statically, and in order to
avoid ABI conflicts, we should use a private namespace for the
SPIRV-Cross dependency to avoid bugs. See SPIRV-Cross issue #902 for
more information. The new namespace is MVK_spirv_cross, and the code
now makes use of the SPIRV_CROSS_NAMESPACE macro rather than spirv_cross.
2019-03-29 11:34:55 +01:00
Bill Hollings
9536538035
Merge pull request #547 from HansKristian-Work/vkcmdfillbuffer-offset-crash
Fix wrong offset for vkCmdFillBuffer on VK_WHOLE_SIZE.
2019-03-27 22:46:55 -04:00
Bill Hollings
29f32a3e4c
Merge pull request #545 from cdavis5e/fix-private-buffer-views
Set options properly on a buffer view's MTLTextureDescriptor.
2019-03-27 22:44:57 -04:00
Chip Davis
354dc32fb9 Set options properly on a buffer view's MTLTextureDescriptor.
The resource options must match between an `MTLBuffer` and any linear
texture created from it. Further, to be writable, the
`MTLTextureDescriptor` should have the `MTLTextureUsageShaderWrite` bit
set.

Fixes #542.
2019-03-27 13:56:42 -05:00
Hans-Kristian Arntzen
bfd4d182cd Fix wrong offset for vkCmdFillBuffer on VK_WHOLE_SIZE.
A double offset would be applied, causing the word count to wrap around
and trigger an assertion and GPU lockup.
2019-03-27 19:56:35 +01:00
Bill Hollings
32137e6da9 Fixed crash within MVKPushConstantsCommandEncoderState when accessing absent
graphics pipeline during a compute stage.

MVKPushConstantsCommandEncoderState test for tessellation only during graphics stages.
Guard against possible missing graphics pipeline even during graphics stages.
2019-03-27 12:40:58 -04:00
Bill Hollings
f31a56a93c Support null device in MVKBaseDeviceObject and MVKDispatchableDeviceObject instances. 2019-03-26 16:49:23 -04:00
Bill Hollings
b3240794fc Fix PVRTC texture content loading via memory mapping.
MoltenVK_Runtime_UserGuide.md: Add limitation explanation
about loading PVRTC using host-visible memory only.
Update What's New document.
2019-03-26 13:31:26 -04:00
Bill Hollings
e4d96f6fa2 Support Xcode 10.2. 2019-03-26 11:50:39 -04:00
Bill Hollings
91f78b6bea Add support for tracking device features enabled during vkCreateDevice().
Enable device features based on content of pCreateDeviceInfo.
Validate requested features are available and return  if not.
Support returning error from vkCreateDevice(), vkFlushMappedMemoryRanges()
and vkInvalidateMappedMemoryRanges().
Update What's New Document.
2019-03-25 19:58:36 -04:00
Bill Hollings
cc2dd1cc21 Clean up sparse binding functions.
Remove "unimplemented" error reporting from sparse binding functions.
As per Vulkan spec, sparse binding query functions simply return zero responses.
vkQueueBindSparse() returns VK_ERROR_FEATURE_NOT_PRESENT error.
2019-03-25 11:48:48 -04:00
Bill Hollings
0ac1edbac0 Project build enhancements, and MoltenVKShaderConverter
tool now validates converted MSL with a test compilation.

Project build scripts now build dylib and framework in separate build directories
to enable MoltenVKShaderConverter to link to static library instead of dynamic library.
Final Package structure remains the same.
In Debug build, copy dylib dSYM files to Package.
Package/Latest directory now links relative to local Debug or Release directory.
Add install option to Makefile.
MoltenVKShaderConverter tool now validates converted MSL with a test compilation.
Clean up various MSL conversion and compilation error logging.
MVKCommandResourceFactory wrap Metal library compile with autorelease pool.
Build ExternalDependencies with same symbol hiding as MoltenVK to suppress visibility warnings.
Update What's New document.
2019-03-22 19:36:21 -04:00
Chip Davis
316429225a Fix updating push constants for tessellation shaders.
Missed this when I was initially implementing this.
2019-03-22 12:57:09 -05:00
Chip Davis
4b0d84e576 vkCmdBlitImage: Remove check for invalid behavior.
According to the Vulkan spec:

> * If either of `srcImage` or `dstImage` was created with a
>   depth/stencil format, the other **must** have exactly the same format

So this should not happen in well-behaved clients.
2019-03-21 15:45:08 -05:00
Bill Hollings
bdaf306233 Update VK_KHR_swapchain and VK_KHR_get_surface_capabilities2 extensions.
Add support for VK_KHR_get_surface_capabilities2 extension.
Implement newer VK_KHR_swapchain extension functions.
Fix when the following functions return VK_INCOMPLETE:
    vkGetPhysicalDeviceSurfaceFormatsKHR()
    vkGetSwapchainImagesKHR()
    vkEnumeratePhysicalDevices()
    vkEnumerateInstanceLayerProperties()
    vkGetPhysicalDeviceQueueFamilyProperties()
CTS: Pass supported *.macos.surface.* and *.macos.swapchain.* tests.
Update What's New document.
2019-03-21 08:53:18 -04:00
Bill Hollings
522f3ad0d4 Merge branch 'master' of https://github.com/KhronosGroup/MoltenVK 2019-03-21 07:07:31 -04:00
Chip Davis
06babd1cdb Move feature setting into the macOS-specific block. 2019-03-20 10:31:58 -05:00
Chip Davis
0a44de3889 MVKDevice: Don't enable the shaderStorageImageArrayDynamicIndexing feature on iOS.
iOS does not actually support arrays of writable textures. At all.
2019-03-20 09:59:51 -05:00
Bill Hollings
614ac65933 Add correct function entry point handling.
Add MVKEntryPoint struct to track entry points as
instance vs device, and core vs enabled extensions.
Add stubs for newer VK_KHR_swapchain functions.
Pass CTS dEQP-VK.api.version_check.entry_points.
Update What's New document.
2019-03-19 16:43:04 -04:00
Chip Davis
4468f36bc6 Support the VK_EXT_host_query_reset extension.
This allows clients to reset query pools on the host, instead of with a
GPU command.

This updates Vulkan headers to 1.1.104... but, there's a problem. This
change has not been merged to `master` in the `Vulkan-Headers` repo yet,
because of an issue building the C++ binding headers. Luckily, we only
need the core C header.
2019-03-17 19:59:15 -05:00
Bill Hollings
caba1186e4
Merge branch 'master' into tessellation 2019-03-15 16:11:11 -04:00
Bill Hollings
e13444e305 Allow zero offset and stride combo in VkVertexInputBindingDescription.
Also fix memory overrun if no VB found with same binding as a VA.
2019-03-14 17:50:20 -04:00
Bill Hollings
05b14366da Use autorelease pool for synchronous command buffer submissions also. 2019-03-12 17:36:01 -04:00
Chip Davis
6061614895 Fix case where all attributes are skipped.
If none of the attributes in a buffer is used but still present, then
the offset will be non-zero, leading us to set a non-zero stride for a
vertex buffer that is not used. This is invalid.

Fixes tessellation in Final Fantasy XIV.
2019-03-11 14:19:49 -05:00
Chip Davis
d50e654acd Fix a possible race condition around MVKMTLBufferAllocation.
I don't think a race is actually possible here, but this makes Thread
Sanitizer happy.
2019-03-11 14:19:49 -05:00
Chip Davis
a1be5a37d3 Fix broken indirect non-tessellated draws. 2019-03-11 14:19:49 -05:00