1211 Commits

Author SHA1 Message Date
Bill Hollings
b09f52c50a Merge branch 'master' of https://github.com/KhronosGroup/MoltenVK 2019-04-11 10:00:20 -04:00
Bill Hollings
562093d2ed
Merge pull request #565 from mbarriault/master
Several fixes regarding tessellation, especially in indexed and instanced rendering
2019-04-11 09:55:14 -04:00
Bill Hollings
f326f0caec Log shader performance statistics in any runtime if
MVKConfiguration::performanceLoggingFrameCount is non-zero.
2019-04-09 23:24:44 -04:00
Michael Barriault
90baed604e Fix crash vertex pre-pass in tessellation pipeline due to being created with line topology but rendered with points. 2019-04-09 20:03:18 +01:00
Michael Barriault
761d80f81f Fix vertex pre-pass in tessellation pipeline not encoding. 2019-04-09 20:00:44 +01:00
Michael Barriault
a995a3b926 Fix patch count in tessellation pipeline. 2019-04-09 19:59:46 +01:00
Michael Barriault
7e1eafcee5 Fix reading storage images in shaders. 2019-04-09 19:59:09 +01:00
Michael Barriault
159a0c3919 Fix Metal version check macro 2019-04-09 19:58:05 +01:00
Bill Hollings
55a0ed95b4
Merge pull request #563 from billhollings/master
Update to latest version of SPIRV-Cross and add Vulkan call tracing option.
2019-04-05 12:55:55 -04:00
Bill Hollings
ef86d58552 Update to latest version of SPIRV-Cross.
Clean up demo build warnings.
Update What's New document.
2019-04-05 12:08:32 -04:00
Bill Hollings
3e5b735355 Add MVK_CONFIG_TRACE_VULKAN_CALLS env var and build setting to log Vulkan calls made by application. 2019-04-03 16:39:27 -04:00
Bill Hollings
2e7bb20835
Merge pull request #562 from billhollings/master
Set MTLRenderPassDescriptor renderTargetWidth & renderTargetHeight only when layered rendering supported, to avoid GPU crashes on older devices.
2019-04-03 16:02:56 -04:00
Bill Hollings
cf13ab08a2 Set MTLRenderPassDescriptor renderTargetWidth & renderTargetHeight
only when layered rendering supported, to avoid GPU crashes on older devices.
2019-04-03 14:58:57 -04:00
Bill Hollings
07771c965c
Merge pull request #560 from billhollings/master
API: Add MVKPhysicalDeviceMetalFeatures::depthSampleCompare & fixes.
2019-04-02 14:21:14 -04:00
Bill Hollings
c388619792 Suppress visibility warning spam when building Debug macOS from SPIRV-Cross Release
Pass -Xlinker -w when building Debug macOS dylibs.
Include -w in OTHER_LDFLAGS when building Debug macOS MoltenVKShaderConverter tool.
2019-04-02 12:25:49 -04:00
Bill Hollings
75a088dbe0 API: Add MVKPhysicalDeviceMetalFeatures::depthSampleCompare.
Set MTLSamplerDescriptor.compareFunction only if depthSampleCompare enabled.
Update VK_MVK_MOLTENVK_SPEC_VERSION to 19.
2019-04-02 00:40:57 -04:00
Bill Hollings
6a77fc950a Clean up recent commits for iOS compatibility.
Test for _pMetalFeatures->layeredRendering before setting
MTLRenderPassDescriptor.renderTargetArrayLength.
Change NSString comparisons using isEqualTo: to isEqualToString:.
2019-04-01 23:05:42 -04:00
Bill Hollings
dfd5638a0f Clean up use of SPIRV_CROSS_NAMESPACE_OVERRIDE in Xcode projects.
Setting of SPIRV_CROSS_NAMESPACE_OVERRIDE in Xcode projects was stomping on DEBUG setting.
Update What's New document.
2019-04-01 22:41:20 -04:00
Bill Hollings
0ce9fccd17
Merge pull request #559 from cdavis5e/rtarray-a12-fix
Actually set the renderTargetArrayLength property on iOS 12.
2019-04-01 21:56:18 -04:00
Bill Hollings
7fd61a4610
Merge pull request #557 from cdavis5e/surface-loss
Handle surface loss.
2019-04-01 21:55:27 -04:00
Chip Davis
9736aace54 Detect surface loss in the swapchain on iOS as well. 2019-04-01 16:43:13 -05:00
Chip Davis
d24ddb1831 Add missing braces. 2019-04-01 16:28:27 -05:00
Chip Davis
77ddaff4d4 Actually set the renderTargetArrayLength property on iOS 12.
Fixes #558.
2019-04-01 13:42:35 -05:00
Chip Davis
b8f22700d5 Handle surface loss.
Sometimes, the `CAMetalLayer` backing a view can be replaced--for
example, when the window is moved to another screen, or the style bits
on the window are changed. In that case, we must allow the client the
opportunity to recreate the surface and swapchain.

Layer-backed views always set themselves as the layer's delegate; we use
this fact to Key-Value Observe the view's `layer` property.

Other alternatives considered:

* Registering for `NSViewGlobalFrameDidChange` notifications. Aside from
  only working on macOS, this doesn't actually catch every case where we
  want to report a lost surface. I'm not even sure it works at all for
  Metal.
* Holding a reference to the view, and checking when its layer property
  has changed.
* Holding a weak reference to the layer; that way, the reference will
  become `nil` when the layer is replaced. But this requires ARC.
2019-04-01 13:11:01 -05:00
Bill Hollings
d95ea7e9a7
Merge pull request #554 from danginsburg/render_area_offset_fix
Fix https://github.com/KhronosGroup/MoltenVK/issues/553 by making the…
2019-03-29 15:16:19 -04:00
danginsburg
7199c2570b Fix https://github.com/KhronosGroup/MoltenVK/issues/553 by making the Metal renderpass descriptor width/height clamped to the renderArea including the offset, not just the extent. 2019-03-29 14:32:27 -04:00
Bill Hollings
3437621f90
Merge pull request #552 from billhollings/master
MSL: Fix crash where variable storage buffer pointers are passed down.
2019-03-29 14:31:48 -04:00
Bill Hollings
4183a6489b
Merge branch 'master' into master 2019-03-29 13:06:00 -04:00
Bill Hollings
6eedbbf5c2
Merge pull request #550 from HansKristian-Work/override-spirv-cross-namespace
Override namespace for SPIRV-Cross.
2019-03-29 12:40:52 -04:00
Hans-Kristian Arntzen
38edfdb3de Override namespace for SPIRV-Cross.
Some projects also link against SPIRV-Cross statically, and in order to
avoid ABI conflicts, we should use a private namespace for the
SPIRV-Cross dependency to avoid bugs. See SPIRV-Cross issue #902 for
more information. The new namespace is MVK_spirv_cross, and the code
now makes use of the SPIRV_CROSS_NAMESPACE macro rather than spirv_cross.
2019-03-29 11:34:55 +01:00
Bill Hollings
0f22e2a70e MSL: Fix crash where variable storage buffer pointers are passed down.
Explicitly build dSYM files in BUILT_PRODUCTS_DIR
to avoid conflict between macOS and iOS build locations.
Update to latest SPIRV-Cross version.
2019-03-28 11:58:05 -04:00
Bill Hollings
9536538035
Merge pull request #547 from HansKristian-Work/vkcmdfillbuffer-offset-crash
Fix wrong offset for vkCmdFillBuffer on VK_WHOLE_SIZE.
2019-03-27 22:46:55 -04:00
Bill Hollings
29f32a3e4c
Merge pull request #545 from cdavis5e/fix-private-buffer-views
Set options properly on a buffer view's MTLTextureDescriptor.
2019-03-27 22:44:57 -04:00
Bill Hollings
cb283a0918
Merge pull request #543 from billhollings/master
CTS fixes. MVKPushConstantsCommandEncoderState compute / tessellation conflict.
2019-03-27 22:44:42 -04:00
Chip Davis
354dc32fb9 Set options properly on a buffer view's MTLTextureDescriptor.
The resource options must match between an `MTLBuffer` and any linear
texture created from it. Further, to be writable, the
`MTLTextureDescriptor` should have the `MTLTextureUsageShaderWrite` bit
set.

Fixes #542.
2019-03-27 13:56:42 -05:00
Hans-Kristian Arntzen
bfd4d182cd Fix wrong offset for vkCmdFillBuffer on VK_WHOLE_SIZE.
A double offset would be applied, causing the word count to wrap around
and trigger an assertion and GPU lockup.
2019-03-27 19:56:35 +01:00
Bill Hollings
32137e6da9 Fixed crash within MVKPushConstantsCommandEncoderState when accessing absent
graphics pipeline during a compute stage.

MVKPushConstantsCommandEncoderState test for tessellation only during graphics stages.
Guard against possible missing graphics pipeline even during graphics stages.
2019-03-27 12:40:58 -04:00
Bill Hollings
f31a56a93c Support null device in MVKBaseDeviceObject and MVKDispatchableDeviceObject instances. 2019-03-26 16:49:23 -04:00
Bill Hollings
ccdfa67a7b
Merge pull request #539 from billhollings/master
Fix PVRTC texture content loading via memory mapping.
2019-03-26 15:06:23 -04:00
Bill Hollings
b3240794fc Fix PVRTC texture content loading via memory mapping.
MoltenVK_Runtime_UserGuide.md: Add limitation explanation
about loading PVRTC using host-visible memory only.
Update What's New document.
2019-03-26 13:31:26 -04:00
Bill Hollings
e4d96f6fa2 Support Xcode 10.2. 2019-03-26 11:50:39 -04:00
Bill Hollings
89a3a511c5
Merge pull request #538 from billhollings/master
Track enabled device features and clean up sparse binding errors.
2019-03-25 22:48:57 -04:00
Bill Hollings
91f78b6bea Add support for tracking device features enabled during vkCreateDevice().
Enable device features based on content of pCreateDeviceInfo.
Validate requested features are available and return  if not.
Support returning error from vkCreateDevice(), vkFlushMappedMemoryRanges()
and vkInvalidateMappedMemoryRanges().
Update What's New Document.
2019-03-25 19:58:36 -04:00
Bill Hollings
cc2dd1cc21 Clean up sparse binding functions.
Remove "unimplemented" error reporting from sparse binding functions.
As per Vulkan spec, sparse binding query functions simply return zero responses.
vkQueueBindSparse() returns VK_ERROR_FEATURE_NOT_PRESENT error.
2019-03-25 11:48:48 -04:00
Bill Hollings
e771f79d5c
Merge pull request #537 from billhollings/master
Project build enhancements, and MoltenVKShaderConverter tool now validates converted MSL with a test compilation.
2019-03-22 20:31:49 -04:00
Bill Hollings
0ac1edbac0 Project build enhancements, and MoltenVKShaderConverter
tool now validates converted MSL with a test compilation.

Project build scripts now build dylib and framework in separate build directories
to enable MoltenVKShaderConverter to link to static library instead of dynamic library.
Final Package structure remains the same.
In Debug build, copy dylib dSYM files to Package.
Package/Latest directory now links relative to local Debug or Release directory.
Add install option to Makefile.
MoltenVKShaderConverter tool now validates converted MSL with a test compilation.
Clean up various MSL conversion and compilation error logging.
MVKCommandResourceFactory wrap Metal library compile with autorelease pool.
Build ExternalDependencies with same symbol hiding as MoltenVK to suppress visibility warnings.
Update What's New document.
2019-03-22 19:36:21 -04:00
Bill Hollings
fbc66c1ea3
Merge pull request #536 from cdavis5e/tess-shader-push-const
Fix updating push constants for tessellation shaders.
2019-03-22 17:53:25 -04:00
Chip Davis
316429225a Fix updating push constants for tessellation shaders.
Missed this when I was initially implementing this.
2019-03-22 12:57:09 -05:00
Bill Hollings
8bbbb442b5
Merge pull request #534 from cdavis5e/unneeded-check
vkCmdBlitImage: Remove check for invalid behavior.
2019-03-22 09:38:43 -04:00
Chip Davis
4b0d84e576 vkCmdBlitImage: Remove check for invalid behavior.
According to the Vulkan spec:

> * If either of `srcImage` or `dstImage` was created with a
>   depth/stencil format, the other **must** have exactly the same format

So this should not happen in well-behaved clients.
2019-03-21 15:45:08 -05:00