526 Commits

Author SHA1 Message Date
Bill Hollings
b4a8f2672c
Merge pull request #364 from cdavis5e/force-signedness
Force signedness of shader vertex attributes to match the host.
2018-12-05 05:20:22 +01:00
Bill Hollings
85ba42a0a7
Merge pull request #366 from cdavis5e/debug-dsym-file
In debug configurations, create a dSYM bundle for libMoltenVK.dylib.
2018-12-04 22:27:58 +01:00
Bill Hollings
23b3837d1e
Merge pull request #365 from cdavis5e/lock-set-texture
MVKImage: Take lock when setting the MTLTexture manually.
2018-12-04 22:26:51 +01:00
Bill Hollings
1aec2cf5e9
Merge pull request #363 from cdavis5e/2dms-array-image
Add support for 2D multisample array textures.
2018-12-04 22:11:05 +01:00
Bill Hollings
44cf6c3bf1
Merge pull request #362 from cdavis5e/relaxed-block-layout
Advertise the VK_KHR_relaxed_block_layout extension.
2018-12-04 22:08:51 +01:00
Bill Hollings
1b99ba03ab
Merge pull request #361 from cdavis5e/khr-maintenance3
Support the VK_KHR_maintenance3 extension.
2018-12-04 22:07:16 +01:00
Bill Hollings
4d432249ea
Merge pull request #360 from cdavis5e/storage-buffer-stg-class
Advertise the VK_KHR_storage_buffer_storage_class extension.
2018-12-04 22:05:08 +01:00
Chip Davis
18fa43994f Force signedness of shader vertex attributes to match the host.
Based on a patch by Stefan Dösinger.

Metal cannot do signedness conversion on vertex attributes, and for good
reason. Putting a `uint4` into an `int4`, or a `char4` into a `uint4`,
would lose those values that are outside the range of the target type.
But putting a `uchar4` into a `short4` or an `int4`, or a `ushort4` into
an `int4`, should work. In that case, force the signedness in the shader
to match the declared type of the host.

Update SPIRV-Cross to pull in the corresponding change. Bump MoltenVK
version.
2018-12-04 15:04:10 -06:00
Chip Davis
3ac51e46bf In debug configurations, create a dSYM bundle for libMoltenVK.dylib. 2018-12-04 13:29:02 -06:00
Stefan Dösinger
fe09f01cbe MVKImage: Take lock when setting the MTLTexture manually. 2018-12-04 13:26:11 -06:00
Chip Davis
f9e78313ba Correct format types of 8/16-bit integer formats.
They were using `Int32`/`UInt32`, which is fine I guess, but wasteful in
the blit/clear shaders. This will be more important later, when I work
around a bug in Metal.
2018-12-04 13:17:27 -06:00
Chip Davis
374741a989 Add support for 2D multisample array textures.
Requires Metal 2.1 on Mac. Not supported at all on iOS.

I'm split as to whether or not to have
`mvkMTLTextureTypeFromVkImageType()` return
`MTLTextureType2DMultisampleArray`.
2018-12-04 13:13:49 -06:00
Chip Davis
2b929c36ae Advertise the VK_KHR_relaxed_block_layout extension.
The recent updates to SPIRV-Cross should enable us to support this.
2018-12-04 13:12:16 -06:00
Chip Davis
08f9da1157 Support the VK_KHR_maintenance3 extension.
This is necessary to support the `VK_EXT_descriptor_indexing` extension.
It's also one step closer to Vulkan 1.1.
2018-12-04 13:10:02 -06:00
Chip Davis
bdbe5c71f8 Advertise the VK_KHR_storage_buffer_storage_class extension.
SPIRV-Cross already handles this. This extension was promoted to core in
Vulkan 1.1, and is a requirement for multiple other extensions, some of
which were also promoted to core in 1.1.
2018-12-04 13:07:51 -06:00
Bill Hollings
cd2217d8eb
Merge pull request #354 from billhollings/master
Change internal use of <MoltenVK/hdr.h> to "hdr.h" to add header path flexibility.
2018-11-24 10:01:12 +01:00
Bill Hollings
2afbcbf0ce Merge branch 'master' of https://github.com/KhronosGroup/MoltenVK 2018-11-23 23:12:12 +01:00
Bill Hollings
d29a2a2401
Merge pull request #351 from danginsburg/parallel_fetch_dependencies
Parallel build for fetchDependencies to speed this up.
2018-11-23 23:10:34 +01:00
Bill Hollings
60b5a34faf Change internal use of <MoltenVK/hdr.h> to "hdr.h" to add header path flexibility.
API-Samples demo use headers from MoltenVK framework.
Cube demo remove reference to framework to include MoltenVK API headers.
2018-11-23 16:58:50 +01:00
Dan Ginsburg
c41301f323 Parallel build for fetchDependencies to speed this up. 2018-11-20 10:35:27 -05:00
Bill Hollings
2c3ba0a4ff
Merge pull request #349 from billhollings/master
Update glslang to version compatible with Vulkan SDK 1.1.92.
2018-11-15 19:38:18 -05:00
Bill Hollings
fa73cdb441 Update glslang to version compatible with Vulkan SDK 1.1.92. 2018-11-16 00:57:39 +01:00
Bill Hollings
e8f29ad1d2
Merge pull request #348 from billhollings/master
Align MoltenVK with Vulkan SDK 1.1.92
2018-11-15 17:17:55 -05:00
Bill Hollings
2f131a7a85 Ensure imageview & sampler descriptor bindings have empty sampler & imageview values,
respectively, to avoid error when releasing them on descriptor binding destruction.
2018-11-15 21:38:02 +01:00
Bill Hollings
d99984e064 Align MoltenVK with Vulkan SDK 1.1.92.
Update to latest dependency libraries for Vulkan SDK 1.1.92.
Generate Hologram demo dispatch files in fetchDependencies and remove them from git.
Update MoltenVK version to 1.0.27.
Update What's New document.
2018-11-15 17:40:15 +01:00
Bill Hollings
ac087a1e55 Remove MVKSignalable class as redundant to MVKRefCountedDeviceObject. 2018-11-13 20:27:30 +01:00
Bill Hollings
946cdd0d45
Merge pull request #329 from cdavis5e/destroyed-resource-descset
Remove destroyed resources from descriptor sets.
2018-11-09 10:27:49 -05:00
Bill Hollings
a55429db62
Merge pull request #343 from cdavis5e/compress-format-non-2d
Forbid compressed formats on non-2D images.
2018-11-09 09:54:37 -05:00
Chip Davis
97b3c568c1 Forbid compressed formats on non-2D images.
Also forbid them on multisampled images.
2018-11-08 15:32:52 -06:00
Chip Davis
154107a0dc Revert "Sink MVKRefCountedDeviceObject into MVKBaseDeviceObject."
This reverts commit b34cc2fa821e1ba9b2e13abf5bdc18b099ed4a83. Doing this
makes anything derived from `MVKBaseDeviceObject` non-copyable.
2018-11-07 15:45:15 -06:00
Chip Davis
b34cc2fa82 Sink MVKRefCountedDeviceObject into MVKBaseDeviceObject.
Now every non-dispatchable device-owned object can be reference-counted,
and thus live beyond destruction by the client.
2018-11-07 12:49:48 -06:00
Bill Hollings
9517c58dbd
Merge pull request #340 from billhollings/master
MoltenVK 1.0.26
2018-11-06 18:33:51 -05:00
Bill Hollings
697cd55e85
Merge pull request #338 from cdavis5e/attrib-divisor-zero
MVKPipeline: Set the stepRate to 0 when the attribute divisor is 0.
2018-11-06 17:45:20 -05:00
Bill Hollings
2fa610a510
Merge pull request #339 from cdavis5e/memoryless-storage
Add a memory type for memoryless storage on iOS.
2018-11-06 17:45:00 -05:00
Chip Davis
325c9f5555 Add a memory type for memoryless storage on iOS.
This exposes `MTLStorageTypeMemoryless` on iOS as lazily allocated
device-private memory. The semantics of lazily allocated memory are
exactly those of memoryless storage: namely, it can only be used with
images, and only those used as transient attachments. This enables
Vulkan clients to take advantage of this new storage mode starting on
iOS 10.
2018-11-06 15:39:16 -06:00
Chip Davis
56b70090b2 MVKPipeline: Set the stepRate to 0 when the attribute divisor is 0.
Otherwise, Metal asserts.
2018-11-06 15:34:03 -06:00
Bill Hollings
759bb6df5c Merge branch 'master' of https://github.com/KhronosGroup/MoltenVK 2018-11-06 16:03:55 -05:00
Bill Hollings
38160b3eb3 MoltenVK 1.0.26.
Fixes to create_dylib.sh to cleanup bitcode and architecture support.
Update to latest SPIRV-Cross version.
Update MoltenVK version to 1.0.26.
Update Xcode projects to Xcode 10.1.
Update What's New document.
2018-11-06 16:01:36 -05:00
Bill Hollings
8a807b7c47
Merge pull request #336 from cdavis5e/no-optimal-shared-mac
MVKImage: Don't say shared memory is allowed on Mac.
2018-11-06 15:48:35 -05:00
Chip Davis
56096fb8be Don't leak resource objects after replacing them in a descriptor. 2018-11-06 01:14:10 -06:00
Chip Davis
01f2751a8b Move shader resources over to MVKRefCountedDeviceObject.
As a result, we can gut all the rest of the code I wrote.
2018-11-06 00:36:27 -06:00
Chip Davis
00bb47ef44 Factor out the reference-counting code from MVKSignalable.
Put it into a base class, MVKRefCountedDeviceObject. The intent is that
MVKImageView, MVKSampler, MVKBuffer, and MVKBufferView will all derive
from this and get reference-counting semantics, which will reduce all
the horrible duplication of code from the original change, and fix the
race condition as well.
2018-11-06 00:07:53 -06:00
Chip Davis
b4aef20c04 Remove destroyed resources from descriptor sets.
According to the Vulkan spec:

  "Entries that are not used by a pipeline can have uninitialized
   descriptors or _descriptors of resources that have been destroyed_,
   and executing a draw or dispatch with such a descriptor set bound
   does not cause undefined behavior." [emphasis added]

But, in the current implementation, if a resource is destroyed, and a
descriptor set to which it was bound is subsequently bound to a
pipeline, then the now-freed object for the destroyed resource will be
passed to Metal, which almost always results in a segfault. To avoid
this, resources now keep track of descriptors to which they are bound,
and tell them to forget the resources when they are destroyed.
Conversely, if a descriptor set is destroyed before its bound resources,
the resources must now not notify the destroyed set. In this case, the
descriptor binding now tells the resource to forget the descriptor.

There is a race condition present if two threads attempt to destroy a
descriptor set and a resource at the same time. I've tried to mitigate
this with locking, but it won't help in the case where the resource
destruction happens first--the descriptor set will subsequently attempt
to modify a freed object. I don't know how to fix this.
2018-11-06 00:07:53 -06:00
Chip Davis
9c9b207b0a MVKImage: Don't say shared memory is allowed on Mac.
It isn't. Unfortunately, we have to say it is allowed for linear images,
per the Vulkan spec.
2018-11-05 16:16:02 -06:00
Bill Hollings
1d64dae0cc
Merge pull request #326 from DiegoAce/master
Force Bitcode When Building
2018-11-05 17:14:57 -05:00
Bill Hollings
976aa8cd47
Merge pull request #335 from ryandesign/script-cleanup
create_dylib.sh cleanup
2018-11-05 16:58:32 -05:00
Bill Hollings
6e1c10e03a
Merge pull request #333 from spadix0/fix-memorytypes-order
Fix memoryTypes order on macOS to match spec
2018-11-05 16:44:15 -05:00
Bill Hollings
e8ca167d5e
Merge pull request #332 from cdavis5e/3d-2d-image-view-checks
MVKImageView: Perform the usage check if we're mapping a subset of a 3D image.
2018-11-05 16:16:18 -05:00
Bill Hollings
3cd21a40d1
Merge pull request #331 from cdavis5e/all-unused-attachments
MVKPipeline: Also create a dummy attachment if all attachments are unused.
2018-11-05 16:13:24 -05:00
Bill Hollings
3b76e73fb3
Merge pull request #330 from cdavis5e/relax-linear-mem
MVKDeviceMemory: Relax memory requirements for linear images.
2018-11-05 16:05:04 -05:00