Client's can run string commands on the server with no rate limit. This means when you run 50k+ commands that are unknown, or spam 30k 'status' commands, you will be able to hang the server for 800/1200ms (15k/30kms if script printing to console is enabled!). Although the netchan processing budget system will kick you, the damage has already been done at this point. This change effectively breaks the ability to DOS the server from the client using networked string commands.
In easier words; binding 'status' to your mousewheel will get you kicked from the server, without hitching the server.
Implement net message process budget (channel gets removed if value is exceeded).
Use 'net_processLimit' to enable the implementation on the server. It will get enabled by default after testing and some cleanup. This helps against people trying to slow the server down by spamming net messages with a higher rate, e.g. using 'bind "mousewheel_up" "status"'.
* Fixed bug where multiple of the same entries get added to the global ban/refuse list.
* Fixed bug where we still use the client instance after deleting it in 'CBanSystem::BanListCheck()'.
* Load banlist at a later state (not at construction of class), this is needed for a future change of adapting the 'business' code to feature the game's FileSystem.
* CServer cleanup.
* More detailed ban messages (banned, added to refused list, removed from slot, etc..).
* Use localization key for banned message ("#Valve_Reject_Banned").
* Add const qualifiers to all CPylon methods.
Note:
* This commit requires changes on the master server, these changes are already performed, however the new master server isn't live yet until we publish the new release.
Set 'survival_wallrun_enabled' and 'survival_wallrun_enabled' to 0 in defaults.
I get a lot of mixed opinions on this, there are people who prefer wallrunning and double jumping, but there are also people who don't want these enabled. I received advice to disable them for defaults for the time being (all br modes and firing range/training modes have them disabled, tdm/ctf and dev_default have them enabled).
Including every map in the playlists is a good idea.
The present issue is WE:AD not being shipped in retail season 3.
It's a separate download.
Setting it to 1 will include it in the randomized map select.
Setting it to 0 will make it able to be used with the playlist but will be exluded from said randomized map select.
It's set to 0 now to avoid the game from closing incase it hits said scenario.
